From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753201AbcDURn5 (ORCPT ); Thu, 21 Apr 2016 13:43:57 -0400 Received: from mail-bn1bbn0102.outbound.protection.outlook.com ([157.56.111.102]:62672 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751720AbcDURny (ORCPT ); Thu, 21 Apr 2016 13:43:54 -0400 X-Greylist: delayed 890 seconds by postgrey-1.27 at vger.kernel.org; Thu, 21 Apr 2016 13:43:53 EDT Authentication-Results: spf=pass (sender IP is 204.77.163.247) smtp.mailfrom=garmin.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=garmin.com; From: "J.D. Schroeder" To: , , , , CC: Jim Lodes , "J.D. Schroeder" Subject: [PATCH v2] OMAPDSS: HDMI5: Change DDC timings Date: Thu, 21 Apr 2016 12:27:49 -0500 Message-ID: <1461259669-5194-1-git-send-email-Linux.HWI@garmin.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1461196973-20370-1-git-send-email-Linux.HWI@garmin.com> References: <1461196973-20370-1-git-send-email-Linux.HWI@garmin.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-11.0.0.4179-8.000.1202-22276.001 X-TM-AS-Result: No--6.695600-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:204.77.163.247;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(438002)(199003)(189002)(586003)(189998001)(107886002)(50986999)(50226001)(5003600100002)(5008740100001)(40036005)(5001770100001)(87936001)(6806005)(11100500001)(4326007)(50466002)(2906002)(76176999)(36756003)(81166005)(2950100001)(4001430100002)(2201001)(229853001)(92566002)(19580405001)(19580395003)(77096005)(47776003)(86362001)(16796002)(48376002)(1096002)(1220700001)(106466001)(5003940100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR04MB227;H:garmin.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD049;1:ef/di9sxDkfwgetUH70AoafZ/Wj2Hd0MDwTav2+IScn+IBJ2oFPN0y6o6Jiw/qT9gnLOCKh3Sfs21oYjzuUmWw09njpvH8oFjmDfvbQ61xJnwYIwDYO/XkEG+bHb9UK/S7XlFKcUHU8HQ3xRXGWc7k/pYZwi3n0CumIhR8otg0DqnvZHh11OGrMcCxMt83RllcTOFrsrOqd1CoYk09mJO8GRSd53zm8b6TmBhw6X2jIEaNb2+8lb6q7w0ruLtpa+gY0AMdFuZJqssVGGIsQIcvIXLSHO/kAyMi7EBtgfkyVdUK9SQLyCs2Pl3hRel6jBofpoVeRIc1dIZcJIUV9yDjPwzvG1hYcf8QL526L/DsGeRm7hv3HgdTDUUWlCoLuXDh38h+FzUPeIpq8O/7YHoQbxlhhKBcPR3hnyUnEeXsyoMRlz/qOTKunxURmBhkh4o+ftNpUa5aE1AB5D1AKehnw2kUFsdja68DX7w/+n5wmfUFnYXdR9jlgd6tIt0p6b X-MS-Office365-Filtering-Correlation-Id: da6cbeaa-5937-47cc-1c32-08d36a0a6cd2 X-Microsoft-Exchange-Diagnostics: 1;BL2PR04MB227;2:MWsamFUe0Gf2c6feUQnEBM1OGUlZeghggTHWhLZzj+ZjqdEQReQ/1B+VXIPSymCmUM3SZ5MUsVcbGlTglo4HDQURaIyn654tctMIliPcEFoO8eK5Qho9XA6rk2IiwxeY5GPo/STsMP34lS3t1DH1lY+P9dj9v55fgr1cpdqFrYTKJ1FqZ3cyvUyOUWif1qBD;3:EStGw/xXikqzBAPja2D/z4VDQ8Vfe6bnSRpvOZWGSdgm13W7XpXJMZ9WggNC07z/Ul8g67WXYVhcrngczq4vp53ekpagqW7hfe3/5ddxMuOpHyIt6mjQEcjcAEkauR9q/u4wnDnJKgJwUUalVNUOzeT8uB5gbV9lDygtWeZuYVTrWZEtDyqlvE/wFIWKqo27KqpyOBZ33QjkgG8+LU1anzGApXP/bMoR9uas2haMD9voKAHTecgHfykwiC1v/55WlEpZG7YgGUzZ3b/5qINgaQ==;25:wK0DFfmkAcJf1PvNOBLX/SJMdM/7Z841Gv8j8Ilsz3se6ReMV7qzriSFiXvAqiICpBUjXqOcnv4hPRn0lYYgmsEGkX6PLKPgbxqQHT/OttXa0YvzM1i2qxVDy1aAY/YaFIHtvqVrY/n+mhbPfxQhs0DWfKT3+jRn/fkcPuQx9FcFNuQciqYy+k1++yza7l0GPPIka0OQCQfS3yE+tZv3wdR2Rn3gHT7NysiZns155KwRvS6cGoYAgPpSJ1y4Lv8Ef0LmVNnUI/G/fvS3aWh4Sk1sc9pcBob4YGTL1dMMN7pjhXIAYX9eLqoIn1gQzHi0Lfr/3NBw3fEHW+05Owd0Ow== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BL2PR04MB227; X-Microsoft-Exchange-Diagnostics: 1;BL2PR04MB227;20:8hAcS9ww37S66fuaB0hSeTAYQHAxiTyl3vHKPsLKtL7+f7RZzg3TDkfzkcIwmPGKHgrYocW/xNJFBdqFy1Ey4cD1tGsRgXfUJ2Rq0rh6sA0ruAqb7JQ738o75KnKOpVL1df7Fwqu6S+UbHOiWy+C2yPceRmjyY9kshjnWoQJN0xoQ9O5CNzrBYTQYoOFb4VuysKLOfg3aCuXkrtsUQSPhcMk7HIKHwD27sDJ7GcdAhVsHUQyKZlA6Fy5V4DnHuj2uvwZU0nV1rzfTyf5D8Ugd3wShBaFgD/ScnZAhhNMojki/e5ycqrpBhCMLHjlnVwSx6WsAqsXv25HHmQZfn7kgitlRQH93Rj3BcQz1iUk6WVw1DsQSXWp+y6N0O+meTfX5Mv77Z57NCODGY5F+c1agChVeXBYgPyWY3DeFrlF8vfMMAb7ezO/+sq1s0OSG67yhIbskt/0m8TPx6IZYuAu4Tu99WVw/D1ZF+6QyS7nGWlZP11kJszpff994UhoS7b/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521026)(601004)(2401047)(13015025)(5005006)(13018025)(8121501046)(13024025)(13023025)(13017025)(3002001)(10201501046)(6055026);SRVR:BL2PR04MB227;BCL:0;PCL:0;RULEID:;SRVR:BL2PR04MB227; X-Microsoft-Exchange-Diagnostics: 1;BL2PR04MB227;4:5XlmTFICKweamKQuT0OY06SrqEF4ehZy0tKvMg70dbj0L3bN8mYpfPhhXaaFaJwxAAT0JScAAJ9iLOmac7gpXyibV4mxSu1eSNJI7hTj2l0xc59Xqi1VPx8/ZpOYpw6pAo+iofbiER/t85TpH7dj+kW4c/mYgYGaGqMS3dHUdsAwUx8lhpZJX1QEgYbwnKIi31tUucuvg7PZI/OJ3Z4vdynnsroUP6ehIYJ3LbyEGX0aYRc5eV7MCF0AFlOTOFpm7ehkjNowGyujcjtSuhE++p33Cz/m1cy0on/dNgeqvIDPul4Ntd3ABWx6buQSWUp+Zt2bFWNSvG5qFBLtqXWIiIdxUY+n9gh5Ppu6InEzi04Tk48zqtHsFTEGGxJnAAKG4JcyfLnWcbu0bo1FLwNP2JeKHwk7nJbSpHnY5nnsnxrk5sMpHLMpxtYHk1l0sQhkOQ2RIbtjNj2BER5K67rVQ+4ou27XJePqKFB2DOm8oUzztsMXrDEPzpKrOobXNk28 X-Forefront-PRVS: 091949432C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR04MB227;23:ELXs3gu0jSEkW8sfHw9jUjP/5+gVLAaBqlTzgJ7WW+?= =?us-ascii?Q?m2RCj1OeWnAyBisf9NU4q0Udssz54ZntkYq6527ExIwQvmi7PCyzBjpjA3yq?= =?us-ascii?Q?UmA134F9wM8RDBXMxUUw0xQXGx5ene6nEAP+ZKHnR6wxIFTh1LVr57c3y3eA?= =?us-ascii?Q?L3WMO2yGeQxYoJJXg2ujyQG+pfNWSDEdTEdGdnRUdmxBySZtSauPliCAXyDh?= =?us-ascii?Q?fa8l7pWgyZW05sQW1RK1fFfMG1s7GrJ2iUTEhs6QywuozKKju4gfiH5oSUvo?= =?us-ascii?Q?tzN2DR24Lz2CQApzUbbseMq9qQMpWpevHlLPMtDeYV5V609QMQPZF4PUcWH6?= =?us-ascii?Q?rP0wk9mnql30WpbEe/0AUfdByB4mxCIMNr/sq7EuXi11zNx0eua2cJPzoK86?= =?us-ascii?Q?hQ1JmZR7Kp08SApeH+mj8C1ZhkAtNAUUvEA6WLKZwUcaa8p+Vl4Rv5c6tyks?= =?us-ascii?Q?1wHHjrZHzSj9DVpcliRHoPuK6haKRx/3Q361AMsONG0Yeeycz1RjFu/vv3hA?= =?us-ascii?Q?mVNhnLkdtemEKlJuU/k4WrDCyQJJNIqQPYoODrR7BG4j0ZDYg2Q1PrXuTaH4?= =?us-ascii?Q?QABX1m8aNLgwrN1EJggKLEke6HzQgZ1YXSouC2+EmDXfbvnxpnR0a8IQuIcY?= =?us-ascii?Q?rtj3R/tITWBiyfLR4h4ALI9cZJdr+2jvf1DTFF0KdgYHiW16FuaO5KMxx9SF?= =?us-ascii?Q?Te35LRB/rn0J26u1Dq6VvD4O4a7s9XPQmGoICAZSVveY49Ox++rDbah4exyN?= =?us-ascii?Q?jMG4a4cMMfvtwb7z6hIZ0EhkEm3/HbenakqtuBOiaNiq/uqQC4rU+qXs9zGL?= =?us-ascii?Q?uuspvL2DwP8hTR5oPkjw1WhKF8NYP6UCu7Yiy6CH6yWimCMvaB7gkAhql521?= =?us-ascii?Q?VKrtHgYkh5IzHt86LGQMHntXbMMt+hPYCqfMk0i7ornm1CrbxmJgf9y/tgL/?= =?us-ascii?Q?PWVo7c2Jg7pi6T/e64E+Jj3Gczp1kHE1z6uo4a8VvMMmWZ38joOchaz96/Ct?= =?us-ascii?Q?pkYx+pKHvtR0R/KQ1ZyEJ0h9t6+TH1gqLSU6L7t16R9Qhu6v8cgHXTGf0REp?= =?us-ascii?Q?iz7Ps=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR04MB227;5:jVlpZdmlQjsNDk9wTZ8MuLyP1xIUkEIjOdbGkZ66iP78lEE6v1Tp4vQ/XTcn3cC3bn42u3r+Sw+5hLlKfmqburfdpv9unH/MtxaRsfe5GwXPCn8kmtvHrpqM1v+OUt+z4U3Ve8iQTfLdBhg8kDajtD4tOL2f7BVVIVCHn0smiE1pnG7N7o0kqs+cPfSGun7n;24:BlOWx5TL9WcG+/N6m7/eGJ0qXjjQ9tF5Zbvjx8OTUXuq5miHuAlQIqJoe35md2jIJXiO+Mcuk2hl5ZEc3QzCS7bqZkGPWdYqVA2r/jf86Rw=;7:1BscvsQ6tBrKqj3TT8JLwICoNizqwIgV5n72qhHmeo3GXG7/4MPmETauEeSOaoBvwBSfa1t7qtSZrLsLwXR++EzGX36Cx32+ILPH96rn6tu7kvHndLaqGkSk1L/p62TxUQgPnIEdpYCtq94+PTKpAyhUcBfNdqn0mbcGq5N1L3L1xpSyNIG2yro9xK3UJLlHg/nw25RJi7xxOPBKOFYtswFH7UZz6pvvMvBaukwReCE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: garmin.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2016 17:28:59.4334 (UTC) X-MS-Exchange-CrossTenant-Id: 38d0d425-ba52-4c0a-a03e-2a65c8e82e2d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38d0d425-ba52-4c0a-a03e-2a65c8e82e2d;Ip=[204.77.163.247];Helo=[garmin.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR04MB227 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jim Lodes The DDC scl high and low times were set to the minimum values from the i2c specification, but the i2c specification takes into account the rise time and fall time to calculate the frequency. To pass HDMI certification DDC can not exceed 100kHz therefore in a system where the rise times and fall times are negligible the high and low times for scl need to be 10us. Signed-off-by: Jim Lodes Signed-off-by: J.D. Schroeder --- drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 4 ++-- drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c index 6a39752..d993f78 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c @@ -51,8 +51,8 @@ static void hdmi_core_ddc_init(struct hdmi_core_data *core) { void __iomem *base = core->base; const unsigned long long iclk = 266000000; /* DSS L3 ICLK */ - const unsigned ss_scl_high = 4000; /* ns */ - const unsigned ss_scl_low = 4700; /* ns */ + const unsigned ss_scl_high = 4600; /* ns */ + const unsigned ss_scl_low = 5400; /* ns */ const unsigned fs_scl_high = 600; /* ns */ const unsigned fs_scl_low = 1300; /* ns */ const unsigned sda_hold = 1000; /* ns */ diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c index 8ea531d..f3e4b81 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c @@ -51,8 +51,8 @@ static void hdmi_core_ddc_init(struct hdmi_core_data *core) { void __iomem *base = core->base; const unsigned long long iclk = 266000000; /* DSS L3 ICLK */ - const unsigned ss_scl_high = 4000; /* ns */ - const unsigned ss_scl_low = 4700; /* ns */ + const unsigned ss_scl_high = 4600; /* ns */ + const unsigned ss_scl_low = 5400; /* ns */ const unsigned fs_scl_high = 600; /* ns */ const unsigned fs_scl_low = 1300; /* ns */ const unsigned sda_hold = 1000; /* ns */ -- 1.9.1