From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Christoph Hellwig <hch@lst.de>, Ming Lin <ming.l@ssi.samsung.com>,
Sagi Grimberg <sagi@grimberg.me>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: [PATCH v2] lib: make sg_pool tristate instead of bool
Date: Sat, 23 Apr 2016 22:44:55 -0400 [thread overview]
Message-ID: <1461465895-676-1-git-send-email-paul.gortmaker@windriver.com> (raw)
The recently added Kconfig controlling compilation of this code is:
lib/Kconfig:config SG_POOL
lib/Kconfig: def_bool n
...meaning that it currently is not being built as a module by anyone,
and that tripped my audit looking for modular code that is essentially
orphaned (i.e. module_exit, and .remove fcns in non-modular drivers.)
In the following discussion, Ming Lin indicated that the original
intention was to have it tristate, so here we convert it accordingly.
Also fix up a couple spelling issues that appear in the surrounding
patch context.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lin <ming.l@ssi.samsung.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[v2: drop modular code removal patch in favour of supporting a modular
build via a one line Kconfig patch as per Ming's comments. Build tested
for allmodconfig on ARM and x86-64 on linux-next. ]
lib/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/Kconfig b/lib/Kconfig
index e04f168f8f42..8de5868804b5 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -528,13 +528,13 @@ config SG_SPLIT
help
Provides a helper to split scatterlists into chunks, each chunk being
a scatterlist. This should be selected by a driver or an API which
- whishes to split a scatterlist amongst multiple DMA channels.
+ wishes to split a scatterlist amongst multiple DMA channels.
config SG_POOL
- def_bool n
+ def_tristate n
help
Provides a helper to allocate chained scatterlists. This should be
- selected by a driver or an API which whishes to allocate chained
+ selected by a driver or an API which wishes to allocate chained
scatterlist.
#
--
2.8.0
next reply other threads:[~2016-04-24 2:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 2:44 Paul Gortmaker [this message]
2016-04-24 3:30 ` [PATCH v2] lib: make sg_pool tristate instead of bool Ming Lin
2016-04-27 23:54 ` Martin K. Petersen
2016-04-28 6:51 ` Christoph Hellwig
2016-04-30 19:58 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461465895-676-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.l@ssi.samsung.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox