From: Joe Perches <joe@perches.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: changbin.du@intel.com, apw@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: add support for checking patch from git repository
Date: Sun, 24 Apr 2016 09:07:21 -0700 [thread overview]
Message-ID: <1461514041.2726.59.camel@perches.com> (raw)
In-Reply-To: <20160424151052.GA12279@earth>
On Sun, 2016-04-24 at 17:10 +0200, Sebastian Reichel wrote:
> On Sun, Apr 24, 2016 at 04:22:45AM -0700, Joe Perches wrote:
> > On Sun, 2016-04-24 at 18:40 +0800, changbin.du@intel.com wrote:
> > > From: "Du, Changbin" <changbin.du@intel.com>
> > > This patch add "-g, --git" option that tread FILE as git commits
> > > expression. You can specify the git commit hash ID expressions,
> > > then these commits from your git repository will be checked.
> > Why would anyone want to use checkpatch on commits already in git?
> It may be in some non-public development branch. Usually when I
> write patches I open a file, change it and commit the result or even
> interim result to have backups and other git features available as
> soon as possible. All testing is done later.
>
> So IMHO this is a really useful feature.
I think it would be a more useful feature for
something like a git pull request rather than
a local git repository.
next prev parent reply other threads:[~2016-04-24 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 10:40 [PATCH] checkpatch.pl: add support for checking patch from git repository changbin.du
2016-04-24 11:22 ` Joe Perches
2016-04-24 15:10 ` Sebastian Reichel
2016-04-24 16:07 ` Joe Perches [this message]
2016-04-24 17:30 ` Sebastian Reichel
2016-04-24 17:43 ` Joe Perches
2016-04-24 18:18 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461514041.2726.59.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=changbin.du@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox