* [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx
@ 2016-04-25 16:08 J.D. Schroeder
2016-04-29 13:19 ` Peter Ujfalusi
0 siblings, 1 reply; 2+ messages in thread
From: J.D. Schroeder @ 2016-04-25 16:08 UTC (permalink / raw)
To: linux-kernel, peter.ujfalusi, lgirdwood, broonie, perex, tiwai,
jsarha, alsa-devel
Cc: Jim Lodes, J.D. Schroeder
From: Jim Lodes <jim.lodes@garmin.com>
The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
input/output status that had already been set by the
davinci_mcasp_set_sysclk function. This commit removes clearing
of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.
Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
---
sound/soc/davinci/davinci-mcasp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index e132498..a1197ad 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);
mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
- ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
+ ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
mcasp->bclk_master = 0;
break;
default:
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx
2016-04-25 16:08 [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx J.D. Schroeder
@ 2016-04-29 13:19 ` Peter Ujfalusi
0 siblings, 0 replies; 2+ messages in thread
From: Peter Ujfalusi @ 2016-04-29 13:19 UTC (permalink / raw)
To: J.D. Schroeder, linux-kernel, lgirdwood, broonie, perex, tiwai,
jsarha, alsa-devel
Cc: Jim Lodes, J.D. Schroeder
On 04/25/2016 07:08 PM, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@garmin.com>
>
> The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
> input/output status that had already been set by the
> davinci_mcasp_set_sysclk function. This commit removes clearing
> of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> ---
> sound/soc/davinci/davinci-mcasp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index e132498..a1197ad 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
> mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);
>
> mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
> - ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
> + ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
> mcasp->bclk_master = 0;
> break;
> default:
>
--
Péter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-29 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-25 16:08 [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx J.D. Schroeder
2016-04-29 13:19 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox