* [PATCH] megaraid_sas: trivial fix, add missing space in dev_err message
@ 2016-04-25 21:58 Colin King
2016-04-26 1:05 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-04-25 21:58 UTC (permalink / raw)
To: Kashyap Desai, Sumit Saxena, Uday Lingala,
James E . J . Bottomley, Martin K . Petersen, Jiri Kosina,
megaraidlinux.pdl, linux-scsi
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Add a missing space in dev_err message, missed because the string
spans a few lines.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index e6ebc7a..1c038bc 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -3345,7 +3345,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance)
if (!list_empty(&cmd->list)) {
dev_notice(&instance->pdev->dev, "ERROR while"
" moving this cmd:%p, %d %p, it was"
- "discovered on some list?\n",
+ " discovered on some list?\n",
cmd, cmd->sync_cmd, cmd->scmd);
list_del_init(&cmd->list);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] megaraid_sas: trivial fix, add missing space in dev_err message
2016-04-25 21:58 [PATCH] megaraid_sas: trivial fix, add missing space in dev_err message Colin King
@ 2016-04-26 1:05 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2016-04-26 1:05 UTC (permalink / raw)
To: Colin King, Kashyap Desai, Sumit Saxena, Uday Lingala,
James E . J . Bottomley, Martin K . Petersen, Jiri Kosina,
megaraidlinux.pdl, linux-scsi
Cc: linux-kernel
On Mon, 2016-04-25 at 22:58 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add a missing space in dev_err message, missed because the string
> spans a few lines.
This is a dev_notice() not dev_err().
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
[]
> @@ -3345,7 +3345,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance)
> if (!list_empty(&cmd->list)) {
> dev_notice(&instance->pdev->dev, "ERROR while"
> " moving this cmd:%p, %d %p, it was"
> - "discovered on some list?\n",
> + " discovered on some list?\n",
> cmd, cmd->sync_cmd, cmd->scmd);
>
> list_del_init(&cmd->list);
Better would be to coalesce the format, but perhaps
this dev_notice should be dev_err?
dev_notice(&instance->pdev->dev,
"ERROR while moving this cmd:%p, %d %p, it was discovered on some list?\n",
cmd, cmd->sync_cmd, cmd->scmd);
And the message seems oddly phrased.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-26 1:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-25 21:58 [PATCH] megaraid_sas: trivial fix, add missing space in dev_err message Colin King
2016-04-26 1:05 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox