From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbcDZBF7 (ORCPT ); Mon, 25 Apr 2016 21:05:59 -0400 Received: from smtprelay0225.hostedemail.com ([216.40.44.225]:36110 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750817AbcDZBF6 (ORCPT ); Mon, 25 Apr 2016 21:05:58 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:4321:5007:7576:9010:10004:10400:10848:11026:11232:11658:11783:11914:12043:12048:12296:12438:12517:12519:12740:13069:13095:13311:13357:13439:13894:14181:14659:14721:21080:21212:21433:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: doll94_6de8a743f2432 X-Filterd-Recvd-Size: 2156 Message-ID: <1461632753.2726.108.camel@perches.com> Subject: Re: [PATCH] megaraid_sas: trivial fix, add missing space in dev_err message From: Joe Perches To: Colin King , Kashyap Desai , Sumit Saxena , Uday Lingala , "James E . J . Bottomley" , "Martin K . Petersen" , Jiri Kosina , megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org Date: Mon, 25 Apr 2016 18:05:53 -0700 In-Reply-To: <1461621523-30162-1-git-send-email-colin.king@canonical.com> References: <1461621523-30162-1-git-send-email-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-04-25 at 22:58 +0100, Colin King wrote: > From: Colin Ian King > > Add a missing space in dev_err message, missed because the string > spans a few lines. This is a dev_notice() not dev_err(). > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c [] > @@ -3345,7 +3345,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance) >   if (!list_empty(&cmd->list)) { >   dev_notice(&instance->pdev->dev, "ERROR while" >   " moving this cmd:%p, %d %p, it was" > - "discovered on some list?\n", > + " discovered on some list?\n", >   cmd, cmd->sync_cmd, cmd->scmd); >   >   list_del_init(&cmd->list); Better would be to coalesce the format, but perhaps this dev_notice should be dev_err? dev_notice(&instance->pdev->dev,    "ERROR while moving this cmd:%p, %d %p, it was discovered on some list?\n", cmd, cmd->sync_cmd, cmd->scmd); And the message seems oddly phrased.