From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752663AbcDZL61 (ORCPT ); Tue, 26 Apr 2016 07:58:27 -0400 Received: from mga11.intel.com ([192.55.52.93]:28267 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbcDZL6Z (ORCPT ); Tue, 26 Apr 2016 07:58:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,536,1455004800"; d="scan'208";a="966740171" Message-ID: <1461671966.17131.63.camel@linux.intel.com> Subject: Re: [PATCH v2 0/3] pinctrl/broxton: enable platform device in the absent of ACPI enumeration From: Andy Shevchenko To: Tan Jui Nee , mika.westerberg@linux.intel.com, heikki.krogerus@linux.intel.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, ptyser@xes-inc.com, lee.jones@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, jonathan.yong@intel.com, ong.hock.yu@intel.com, weifeng.voon@intel.com, wan.ahmad.zainie.wan.mohamad@intel.com Date: Tue, 26 Apr 2016 14:59:26 +0300 In-Reply-To: <1461650991-15185-1-git-send-email-jui.nee.tan@intel.com> References: <1461650991-15185-1-git-send-email-jui.nee.tan@intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-04-26 at 14:09 +0800, Tan Jui Nee wrote: > Hi, > The patches are to cater the need for non-ACPI system whereby > a platform device has to be created in order to bind with > Apollo Lake Pinctrl GPIO platform driver. > > The MMIO BAR is accessed over the Primary to Sideband bridge > (P2SB). Since the BIOS prevents the P2SB device from being > enumerated by the PCI subsystem, so we need to hide/unhide P2SB > to lookup the P2SB BAR and pass the PCI BAR address to the gpio > platform driver. > > All these three patches have dependencies on each other. > Lee, Linus, I'm fine with the series, though I doubt which solution is better to have the original driver independent as much as possible from p2sb. > Changes from V1: > - Add new config option CONFIG_X86_INTEL_NON_ACPI and "select > PINCTRL" >   to fix kbuildbot error > > Andy Shevchenko (1): >   x86/platform/p2sb: New Primary to Sideband bridge support driver for >     Intel SOC's > > Tan Jui Nee (2): >   pinctrl/broxton: enable platform device in the absent of ACPI >     enumeration >   mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in >     non-ACPI system > >  arch/x86/Kconfig                        |  14 ++++ >  arch/x86/include/asm/p2sb.h             |  27 +++++++ >  arch/x86/platform/intel/Makefile        |   1 + >  arch/x86/platform/intel/p2sb.c          |  99 > ++++++++++++++++++++++++ >  drivers/mfd/Kconfig                     |   3 +- >  drivers/mfd/lpc_ich.c                   | 128 > ++++++++++++++++++++++++++++++++ >  drivers/pinctrl/intel/pinctrl-broxton.c |  43 ++++++++--- >  7 files changed, 302 insertions(+), 13 deletions(-) >  create mode 100644 arch/x86/include/asm/p2sb.h >  create mode 100644 arch/x86/platform/intel/p2sb.c > -- Andy Shevchenko Intel Finland Oy