public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Max Uvarov <muvarov@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
	sergei.shtylyov@cogentembedded.com,
	Max Uvarov <muvarov@gmail.com>
Subject: [PATCHv2] musb_host: fix lockup on rxcsr_h_error
Date: Wed, 27 Apr 2016 09:51:58 +0300	[thread overview]
Message-ID: <1461739918-9583-1-git-send-email-muvarov@gmail.com> (raw)

Fix soft lockup when resetting remote device attached
to usb host. Configuration:
pppd -> musb hub -> usb-serial -> gsm modem
When gsm modem resets, musb rolls in incoming rx interrupts
which does not give any time to other application as result
it totally lock ups. Solution is to keep original logic for RXCSR_H_ERROR
and merge RXCSR_DATAERROR and RXCSR_H_ERROR branches to call same code
for setting rx stall with MUSB_RXCSR_H_WZC_BITS.

Signed-off-by: Max Uvarov <muvarov@gmail.com>
---
 v2: use bitwise or for error flags before logical and. (Sergei Shtylyov).

 drivers/usb/musb/musb_host.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index c3d5fc9..2d9aa78 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -1592,14 +1592,12 @@ void musb_host_rx(struct musb *musb, u8 epnum)
 
 		/* stall; record URB status */
 		status = -EPIPE;
+	} else if (rx_csr & (MUSB_RXCSR_DATAERROR | MUSB_RXCSR_H_ERROR)) {
 
-	} else if (rx_csr & MUSB_RXCSR_H_ERROR) {
-		dev_dbg(musb->controller, "end %d RX proto error\n", epnum);
-
-		status = -EPROTO;
-		musb_writeb(epio, MUSB_RXINTERVAL, 0);
-
-	} else if (rx_csr & MUSB_RXCSR_DATAERROR) {
+		if (rx_csr & MUSB_RXCSR_H_ERROR) {
+			status = -EPROTO;
+			musb_writeb(epio, MUSB_RXINTERVAL, 0);
+		}
 
 		if (USB_ENDPOINT_XFER_ISOC != qh->type) {
 			dev_dbg(musb->controller, "RX end %d NAK timeout\n", epnum);
-- 
1.9.1

             reply	other threads:[~2016-04-27  6:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27  6:51 Max Uvarov [this message]
2016-04-27 15:46 ` [PATCHv2] musb_host: fix lockup on rxcsr_h_error Bin Liu
2016-04-27 18:26   ` Maxim Uvarov
2016-04-27 19:13     ` Bin Liu
2016-04-27 21:28       ` Bin Liu
2016-04-28  6:51         ` Maxim Uvarov
2016-04-28 14:37           ` Bin Liu
2016-05-03 10:03             ` Yegor Yefremov
2016-05-03 13:48               ` Bin Liu
2016-05-03 14:25                 ` Yegor Yefremov
2016-05-03 14:35                   ` Bin Liu
2016-05-04 14:49                     ` Yegor Yefremov
2016-05-04 18:56                       ` Bin Liu
2016-05-04 19:02                         ` Sergei Shtylyov
2016-05-04 19:17                           ` Bin Liu
2016-05-04 20:19                             ` Greg KH
2016-05-04 20:47                               ` Bin Liu
2016-05-05 13:21                             ` Sergei Shtylyov
2016-05-05 13:31                               ` Bin Liu
2016-05-05 13:39                                 ` Sergei Shtylyov
2016-05-05 13:45                                   ` Bin Liu
2018-01-25 15:45                   ` Bin Liu
2018-01-25 16:24                     ` Maxim Uvarov
2018-01-25 16:31                       ` Bin Liu
2018-01-26  9:24                         ` Maxim Uvarov
2018-02-08  2:38                           ` Bin Liu
2018-01-26 10:42                       ` Tomas Paukrt
2018-08-06 13:19                         ` Tomas Paukrt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461739918-9583-1-git-send-email-muvarov@gmail.com \
    --to=muvarov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox