From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752636AbcD0Iie (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Apr 2016 04:38:34 -0400
Received: from mga01.intel.com ([192.55.52.88]:53932 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752352AbcD0Iic (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Apr 2016 04:38:32 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,540,1455004800"; 
   d="scan'208";a="941149626"
Message-ID: <1461746373.17131.121.camel@linux.intel.com>
Subject: Re: [PATCH v6 2/4] dmaengine: dw: revisit data_width property
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Viresh Kumar <vireshk@kernel.org>, Vinod Koul <vinod.koul@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dmaengine <dmaengine@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
        Vineet Gupta <vgupta@synopsys.com>, Tejun Heo <tj@kernel.org>
Date: Wed, 27 Apr 2016 11:39:33 +0300
In-Reply-To: <20160427083056.GJ4225@vireshk-i7>
References: <andriy.shevchenko@linux.intel.com>
	 <1461587709-147048-1-git-send-email-andriy.shevchenko@linux.intel.com>
	 <1461587709-147048-3-git-send-email-andriy.shevchenko@linux.intel.com>
	 <20160427064317.GA4225@vireshk-i7>
	 <CAHp75Vc=EZ1gLHpackYEAQXuTs_WCqOP1bk0SBkLJHdje3zCug@mail.gmail.com>
	 <20160427083056.GJ4225@vireshk-i7>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-04-27 at 14:00 +0530, Viresh Kumar wrote:
> On 27-04-16, 11:25, Andy Shevchenko wrote:
> > 
> > -- data_width: Maximum data width supported by hardware per AHB
> > > > master
> > > > -  (0 - 8bits, 1 - 16bits, ..., 5 - 256bits)
> > > > +- data-width: Maximum data width supported by hardware per AHB
> > > > master
> > > > +  (in bytes, power of 2)

> 
> But, the DT documentation doesn't contain the old property now but the
> code
> does. I think you are required to keep the bindings currently
> supported by the
> kernel in there. You can mark them deprecated, but can't remove them.

This point I take, indeed.

Will update series soon. Thanks for review.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy