From: Deepa Dinamani <deepa.kernel@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, y2038@lists.linaro.org,
linux-fsdevel@vger.kernel.org,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 3/3] time: Remove timespec_add_safe()
Date: Fri, 29 Apr 2016 09:39:49 -0700 [thread overview]
Message-ID: <1461947989-21926-4-git-send-email-deepa.kernel@gmail.com> (raw)
In-Reply-To: <1461947989-21926-1-git-send-email-deepa.kernel@gmail.com>
All references to timespec_add_safe() now use
timespec64_add_safe().
The plan is to replace struct timespec references
with struct timespec64 throughout the kernel as
timespec is not y2038 safe.
Drop timespec_add_safe() and use timespec64_add_safe()
for all architectures.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
include/linux/time64.h | 15 +++++++--------
kernel/time/time.c | 4 ----
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/include/linux/time64.h b/include/linux/time64.h
index 1778937..7e5d2fa 100644
--- a/include/linux/time64.h
+++ b/include/linux/time64.h
@@ -65,7 +65,6 @@ static inline struct itimerspec64 itimerspec_to_itimerspec64(struct itimerspec *
# define timespec64_equal timespec_equal
# define timespec64_compare timespec_compare
# define set_normalized_timespec64 set_normalized_timespec
-# define timespec64_add_safe timespec_add_safe
# define timespec64_add timespec_add
# define timespec64_sub timespec_sub
# define timespec64_valid timespec_valid
@@ -134,13 +133,6 @@ static inline int timespec64_compare(const struct timespec64 *lhs, const struct
extern void set_normalized_timespec64(struct timespec64 *ts, time64_t sec, s64 nsec);
-/*
- * timespec64_add_safe assumes both values are positive and checks for
- * overflow. It will return TIME64_MAX in case of overflow.
- */
-extern struct timespec64 timespec64_add_safe(const struct timespec64 lhs,
- const struct timespec64 rhs);
-
static inline struct timespec64 timespec64_add(struct timespec64 lhs,
struct timespec64 rhs)
{
@@ -222,4 +214,11 @@ static __always_inline void timespec64_add_ns(struct timespec64 *a, u64 ns)
#endif
+/*
+ * timespec64_add_safe assumes both values are positive and checks for
+ * overflow. It will return TIME64_MAX in case of overflow.
+ */
+extern struct timespec64 timespec64_add_safe(const struct timespec64 lhs,
+ const struct timespec64 rhs);
+
#endif /* _LINUX_TIME64_H */
diff --git a/kernel/time/time.c b/kernel/time/time.c
index 558f5fe..703306a 100644
--- a/kernel/time/time.c
+++ b/kernel/time/time.c
@@ -770,8 +770,6 @@ struct timespec timespec_add_safe(const struct timespec lhs,
return res;
}
-#if __BITS_PER_LONG != 64
-
/*
* Add two timespec64 values and do a safety check for overflow.
* It's assumed that both values are valid (>= 0).
@@ -792,5 +790,3 @@ struct timespec64 timespec64_add_safe(const struct timespec64 lhs,
return res;
}
-
-#endif
--
1.9.1
prev parent reply other threads:[~2016-04-29 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 16:39 [PATCH 0/3] Use timespec64 for select like timeouts Deepa Dinamani
2016-04-29 16:39 ` [PATCH 1/3] time: Add missing implementation for timespec64_add_safe() Deepa Dinamani
2016-05-04 15:54 ` Deepa Dinamani
2016-05-04 18:31 ` John Stultz
2016-04-29 16:39 ` [PATCH 2/3] fs: poll/select/recvmmsg: use timespec64 for timeout events Deepa Dinamani
2016-05-04 19:24 ` [RESEND PATCH " Deepa Dinamani
2016-05-04 20:04 ` John Stultz
2016-05-04 21:08 ` [Y2038] " Arnd Bergmann
2016-05-04 23:51 ` Andrew Morton
2016-05-05 0:01 ` John Stultz
2016-05-06 19:45 ` David Miller
2016-04-29 16:39 ` Deepa Dinamani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461947989-21926-4-git-send-email-deepa.kernel@gmail.com \
--to=deepa.kernel@gmail.com \
--cc=arnd@arndb.de \
--cc=john.stultz@linaro.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox