From: linmiaohe <linmiaohe@huawei.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: "oleg@redhat.com" <oleg@redhat.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"madhuparnabhowmik10@gmail.com" <madhuparnabhowmik10@gmail.com>,
"gustavoars@kernel.org" <gustavoars@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] signal: clean up codestyle
Date: Tue, 1 Sep 2020 12:47:17 +0000 [thread overview]
Message-ID: <1461a6c6bfe34ae9a5220a7d47d304e8@huawei.com> (raw)
Christian Brauner <christian.brauner@ubuntu.com> wrote:
> On Tue, Sep 01, 2020 at 07:58:00AM -0400, Miaohe Lin wrote:
> No functional change intended.
>Hey Miaohe,
>
>Thank you for the patch.
>I'm sure this is well-intended but afaict the whole file has more or less a consistent style already where e.g. sig-1 without spaces seems to be preferred. The same for the casts where most places use a single space.
>
>Now, I know CodingStyle.rst is on your side at least when it comes to the first point:
>
>Use one space around (on each side of) most binary and ternary operators, such as any of these::
>
> = + - < > * / % | & ^ <= >= == != ? :
>
>but then you'd need to change each place in kernel/signal.c where that is currently not the case. Otherwise we end up with a weird mix.
>
>Thanks!
>Christian
>
Many thanks for your reply. It looks it's better to make codestyle consistent. Will do it when I'am free. :)
Thanks again.
next reply other threads:[~2020-09-01 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 12:47 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-03 1:54 [PATCH] signal: clean up codestyle linmiaohe
2020-09-02 1:34 linmiaohe
2020-09-02 8:47 ` Christian Brauner
2020-09-01 11:58 Miaohe Lin
2020-09-01 12:20 ` Christian Brauner
2020-09-01 16:39 ` Oleg Nesterov
2020-09-01 16:42 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461a6c6bfe34ae9a5220a7d47d304e8@huawei.com \
--to=linmiaohe@huawei.com \
--cc=axboe@kernel.dk \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox