From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756568AbcECUku (ORCPT ); Tue, 3 May 2016 16:40:50 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:37227 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756181AbcECUks (ORCPT ); Tue, 3 May 2016 16:40:48 -0400 Message-ID: <1462308044.10444.19.camel@sipsolutions.net> Subject: Re: [PATCH] fix infoleak in wireless From: Johannes Berg To: Kangjie Lu Cc: davem@davemloft.net, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Kangjie Lu Date: Tue, 03 May 2016 22:40:44 +0200 In-Reply-To: <1462308013-6032-1-git-send-email-kjlu@gatech.edu> (sfid-20160503_223714_829563_B6EE96BB) References: <1462308013-6032-1-git-send-email-kjlu@gatech.edu> (sfid-20160503_223714_829563_B6EE96BB) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-05-03 at 16:40 -0400, Kangjie Lu wrote: > The 6-bytes array “mac_addr” is not initialized in the dump_station > implementations of > “drivers/staging/wilc1000/wilc_wfi_cfgoperations.c” > and “drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c”, so all 6 > bytes may be leaked. Like I said to you before, this makes those implementations completely broken. I'm not going to apply this patch. If you want, feel free to send patches to Greg to remove those dump_station implementations that are completely broken and that can never do anything useful. johannes