From: buzdelabuz2@gmail.com
To: kieran@ksquared.org.uk, jan.kiszka@siemens.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] Fix issue with dmesg.py and python 3.X
Date: Tue, 3 May 2016 23:12:56 -0400 [thread overview]
Message-ID: <1462331576-5570-2-git-send-email-buzdelabuz2+git@gmail.com> (raw)
In-Reply-To: <1462331576-5570-1-git-send-email-buzdelabuz2+git@gmail.com>
From: Dom Cote <buzdelabuz2+git@gmail.com>
Replace the addition (+) of 2 python 'memoryview' objects
with the addition of 2 'bytes' objects, convert the result
back to memoryview.
Tested with python 3.4 and 2.7
Tested with gdb 7.7
Signed-off-by: Dom Cote <buzdelabuz2+git@gmail.com>
---
scripts/gdb/linux/dmesg.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/scripts/gdb/linux/dmesg.py b/scripts/gdb/linux/dmesg.py
index 927d0d2a3145..04d6719067f2 100644
--- a/scripts/gdb/linux/dmesg.py
+++ b/scripts/gdb/linux/dmesg.py
@@ -33,11 +33,12 @@ class LxDmesg(gdb.Command):
if log_first_idx < log_next_idx:
log_buf_2nd_half = -1
length = log_next_idx - log_first_idx
- log_buf = inf.read_memory(start, length)
+ log_buf = utils.read_memoryview(inf, start, length).tobytes()
else:
log_buf_2nd_half = log_buf_len - log_first_idx
- log_buf = inf.read_memory(start, log_buf_2nd_half) + \
- inf.read_memory(log_buf_addr, log_next_idx)
+ a = utils.read_memoryview(inf, start, log_buf_2nd_half)
+ b = utils.read_memoryview(inf, log_buf_addr, log_next_idx)
+ log_buf = a.tobytes() + b.tobytes()
pos = 0
while pos < log_buf.__len__():
--
2.8.2
next prev parent reply other threads:[~2016-05-04 3:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 3:12 [PATCH 1/2] Improve types abstraction for gdb python scripts buzdelabuz2
2016-05-04 3:12 ` buzdelabuz2 [this message]
2016-05-04 5:41 ` [PATCH 2/2] Fix issue with dmesg.py and python 3.X Jan Kiszka
2016-05-04 12:37 ` Kieran Bingham
2016-05-04 12:37 ` [PATCH] scripts/gdb: decode bytestream on dmesg for Python3 Kieran Bingham
2016-05-05 14:20 ` Dom Cote
2016-05-04 12:37 ` [PATCH 1/2] Improve types abstraction for gdb python scripts Kieran Bingham
-- strict thread matches above, loose matches on Subject: below --
2016-05-04 3:08 buzdelabuz2
2016-05-04 3:08 ` [PATCH 2/2] Fix issue with dmesg.py and python 3.X buzdelabuz2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462331576-5570-2-git-send-email-buzdelabuz2+git@gmail.com \
--to=buzdelabuz2@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kieran@ksquared.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox