From: "Andrew F. Davis" <afd@ti.com>
To: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jonathan Corbet <corbet@lwn.net>, Suman Anna <s-anna@ti.com>
Cc: <linux-remoteproc@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, "Andrew F . Davis" <afd@ti.com>
Subject: [PATCH 4/4] rpmsg: use module_rpmsg_driver in existing drivers and examples
Date: Wed, 4 May 2016 13:34:15 -0500 [thread overview]
Message-ID: <1462386855-17381-4-git-send-email-afd@ti.com> (raw)
In-Reply-To: <1462386855-17381-1-git-send-email-afd@ti.com>
Existing drivers and examples are updated to use the
module_rpmsg_driver helper macro.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
Documentation/rpmsg.txt | 14 +-------------
samples/rpmsg/rpmsg_client_sample.c | 13 +------------
2 files changed, 2 insertions(+), 25 deletions(-)
diff --git a/Documentation/rpmsg.txt b/Documentation/rpmsg.txt
index 1d88426..b19700c 100644
--- a/Documentation/rpmsg.txt
+++ b/Documentation/rpmsg.txt
@@ -202,7 +202,6 @@ with the payload of the inbound message).
a pointer to a previously-registered rpmsg_driver struct.
Returns 0 on success, and an appropriate error value on failure.
-
3. Typical usage
The following is a simple rpmsg driver, that sends an "hello!" message
@@ -254,18 +253,7 @@ static struct rpmsg_driver rpmsg_sample_client = {
.callback = rpmsg_sample_cb,
.remove = rpmsg_sample_remove,
};
-
-static int __init init(void)
-{
- return register_rpmsg_driver(&rpmsg_sample_client);
-}
-module_init(init);
-
-static void __exit fini(void)
-{
- unregister_rpmsg_driver(&rpmsg_sample_client);
-}
-module_exit(fini);
+module_rpmsg_driver(rpmsg_sample_client);
Note: a similar sample which can be built and loaded can be found
in samples/rpmsg/.
diff --git a/samples/rpmsg/rpmsg_client_sample.c b/samples/rpmsg/rpmsg_client_sample.c
index 82ed288..d0e249c9 100644
--- a/samples/rpmsg/rpmsg_client_sample.c
+++ b/samples/rpmsg/rpmsg_client_sample.c
@@ -82,18 +82,7 @@ static struct rpmsg_driver rpmsg_sample_client = {
.callback = rpmsg_sample_cb,
.remove = rpmsg_sample_remove,
};
-
-static int __init rpmsg_client_sample_init(void)
-{
- return register_rpmsg_driver(&rpmsg_sample_client);
-}
-module_init(rpmsg_client_sample_init);
-
-static void __exit rpmsg_client_sample_fini(void)
-{
- unregister_rpmsg_driver(&rpmsg_sample_client);
-}
-module_exit(rpmsg_client_sample_fini);
+module_rpmsg_driver(rpmsg_sample_client);
MODULE_DESCRIPTION("Remote processor messaging sample client driver");
MODULE_LICENSE("GPL v2");
--
2.8.2
next prev parent reply other threads:[~2016-05-04 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 18:34 [PATCH 1/4] rpmsg: add THIS_MODULE to rpmsg_driver in rpmsg core Andrew F. Davis
2016-05-04 18:34 ` [PATCH 2/4] rpmsg: drop owner assignment from spi_drivers Andrew F. Davis
2016-05-04 18:55 ` Suman Anna
2016-05-04 18:57 ` Andrew F. Davis
2016-05-04 18:34 ` [PATCH 3/4] rpmsg: add helper macro module_rpmsg_driver Andrew F. Davis
2016-05-04 18:54 ` Suman Anna
2016-05-04 18:58 ` Andrew F. Davis
2016-05-04 18:34 ` Andrew F. Davis [this message]
2016-05-04 18:56 ` [PATCH 1/4] rpmsg: add THIS_MODULE to rpmsg_driver in rpmsg core Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462386855-17381-4-git-send-email-afd@ti.com \
--to=afd@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox