From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755067AbcEERyR (ORCPT ); Thu, 5 May 2016 13:54:17 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:36796 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbcEERyO (ORCPT ); Thu, 5 May 2016 13:54:14 -0400 Message-ID: <1462470851.2404.6.camel@nexus-software.ie> Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface From: "Bryan O'Donoghue" To: Andy Shevchenko , Peter Hurley , linux-serial@vger.kernel.org, Vinod Koul , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Greg Kroah-Hartman , ismo.puustinen@intel.com, Heikki Krogerus Date: Thu, 05 May 2016 18:54:11 +0100 In-Reply-To: <1461764894-14891-4-git-send-email-andriy.shevchenko@linux.intel.com> References: <1461764894-14891-1-git-send-email-andriy.shevchenko@linux.intel.com> <1461764894-14891-4-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Nexus Software Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote: > + bool polarity; So this variable is not very intuitively named. You end up setting somepointer->polarity = true; in a later patch. Since you're respining a V4 I'd suggest a name that describes a little bit better than polarity. Setting polarity = true is a little bit liked being asked "you you like ice-cream or apple pie" and then saying "yes please". --- bod