From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Peter Hurley <peter@hurleysoftware.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Vinod Koul <vinod.koul@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dmaengine <dmaengine@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Puustinen, Ismo" <ismo.puustinen@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v3 09/11] serial: 8250_lpss: move Quark code from PCI driver
Date: Fri, 06 May 2016 13:39:16 +0300 [thread overview]
Message-ID: <1462531156.17131.274.camel@linux.intel.com> (raw)
In-Reply-To: <1462470555.2404.3.camel@nexus-software.ie>
On Thu, 2016-05-05 at 18:49 +0100, Bryan O'Donoghue wrote:
> On Wed, 2016-05-04 at 20:43 +0300, Andy Shevchenko wrote:
> >
> > >
> > > Could you then select CONFIG_SERIAL_8250_LPSS when
> > > CONFIG_X86_INTEL_QUARK is true - since it will be a dependency.
> > Answered to this in the other email, but can repeat my question. Do
> > you
> > propose a new behaviour? Otherwise how does it work right now?
> I just mean when someone selects CONFIG_X86_INTEL_QUARK that, that
> kconfig option will select CONFIG_SERIAL_8250_LPSS automatically.
>
> Maybe that's a bad idea .. I can't think of another driver that would
> be selected like that - though OTOH now that we're moving our
> perfectly
> normal PCI device into this LPSS shim my *feeling* is that it should
> be
> selected automagically.
It's still a PCI driver, just separated from 8250_pci.c.
> Feel free not to do that though - so long as you document the change
> in
> kconfig so that a casual reader understands the entry is moved I think
> it should suffice.
I've already updated (locally) help notice as you suggested.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-05-06 10:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 13:48 [PATCH v3 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 01/11] dmaengine: dw: keep copy of custom slave config in dwc Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 02/11] dmaengine: dw: provide probe(), remove() stubs for users Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface Andy Shevchenko
2016-05-05 17:54 ` Bryan O'Donoghue
2016-05-06 10:42 ` Andy Shevchenko
2016-05-06 11:10 ` Bryan O'Donoghue
2016-04-27 13:48 ` [PATCH v3 04/11] dmaengine: dw: override LLP support if asked in platform data Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 05/11] serial: 8250_dma: switch to new dmaengine_terminate_* API Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 06/11] serial: 8250_dma: adjust DMA address of the UART Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 07/11] serial: 8250: enable AFE on ports where FIFO is 16 bytes Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 08/11] serial: 8250_lpss: split LPSS driver to separate module Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 09/11] serial: 8250_lpss: move Quark code from PCI driver Andy Shevchenko
2016-05-04 9:31 ` Bryan O'Donoghue
2016-05-04 9:42 ` Andy Shevchenko
2016-05-04 9:51 ` Bryan O'Donoghue
2016-05-04 10:03 ` Andy Shevchenko
2016-05-04 11:01 ` Bryan O'Donoghue
2016-05-04 11:20 ` Andy Shevchenko
2016-05-04 14:37 ` Bryan O'Donoghue
2016-05-04 14:55 ` Andy Shevchenko
2016-05-04 14:51 ` Bryan O'Donoghue
2016-05-04 17:43 ` Andy Shevchenko
2016-05-05 17:49 ` Bryan O'Donoghue
2016-05-06 10:39 ` Andy Shevchenko [this message]
2016-05-04 10:04 ` Heikki Krogerus
2016-04-27 13:48 ` [PATCH v3 10/11] serial: 8250_lpss: enable MSI for Intel Quark Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 11/11] serial: 8250_lpss: enable DMA on Intel Quark UART Andy Shevchenko
2016-04-28 17:35 ` [PATCH v3 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Bryan O'Donoghue
2016-05-03 22:55 ` Greg Kroah-Hartman
2016-05-04 9:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462531156.17131.274.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ismo.puustinen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=pure.logic@nexus-software.ie \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).