From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757930AbcEFKkz (ORCPT ); Fri, 6 May 2016 06:40:55 -0400 Received: from mga11.intel.com ([192.55.52.93]:12573 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594AbcEFKky (ORCPT ); Fri, 6 May 2016 06:40:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,586,1455004800"; d="scan'208";a="960161102" Message-ID: <1462531320.17131.277.camel@linux.intel.com> Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface From: Andy Shevchenko To: "Bryan O'Donoghue" , Peter Hurley , linux-serial@vger.kernel.org, Vinod Koul , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Greg Kroah-Hartman , ismo.puustinen@intel.com, Heikki Krogerus Date: Fri, 06 May 2016 13:42:00 +0300 In-Reply-To: <1462470851.2404.6.camel@nexus-software.ie> References: <1461764894-14891-1-git-send-email-andriy.shevchenko@linux.intel.com> <1461764894-14891-4-git-send-email-andriy.shevchenko@linux.intel.com> <1462470851.2404.6.camel@nexus-software.ie> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-05-05 at 18:54 +0100, Bryan O'Donoghue wrote: > On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote: > > > > +       bool                    polarity; > So this variable is not very intuitively named. There is a help above. This is a property of the Synopsys DesignWare DMA engine. Anyone familiar with datasheet easily understands this. > > You end up setting somepointer->polarity = true; in a later patch.  > > Since you're respining a V4 I'd suggest a name that describes a little > bit better than polarity. Setting polarity = true is a little bit > liked > being asked "you you like ice-cream or apple pie" and then saying "yes > please". It's about handshake interface polarity, so, what about hs_polarity? --  Andy Shevchenko Intel Finland Oy