From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932228AbcEFNho (ORCPT ); Fri, 6 May 2016 09:37:44 -0400 Received: from mga11.intel.com ([192.55.52.93]:5118 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758125AbcEFNhm (ORCPT ); Fri, 6 May 2016 09:37:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,587,1455004800"; d="scan'208";a="947610014" Message-ID: <1462541926.17131.285.camel@linux.intel.com> Subject: Re: [PATCH v1 0/2] dmaengine: urgent fix to prevent regression in UART From: Andy Shevchenko To: Vinod Koul , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Peter Hurley , linux-serial@vger.kernel.org Cc: Heikki Krogerus Date: Fri, 06 May 2016 16:38:46 +0300 In-Reply-To: <1462390180-82368-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1462390180-82368-1-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Cc: Heikki On Wed, 2016-05-04 at 22:29 +0300, Andy Shevchenko wrote: > There are two patches, first of which is an urgent fix to prevent a > regression > when UART driver can't acquire DMA channel due to DMA engine which > doesn't > support DMA_CYCLIC. Have to add the following. The commit ec5a11a91eec ("serial: 8250: Validate dmaengine rx chan meets requirements") brought a check for DMA capabilities and UART will not acquire a DMA channel if DMA engine doesn't support both DMA_CYCLIC _and_ DMA_SLAVE. The first patch in the series changes the logic from _and_ to _or_. > > Andy Shevchenko (2): >   dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC >   dmaengine: rename cmd_pause to cmd_suspend > >  drivers/dma/dmaengine.c               | 8 ++++---- >  drivers/tty/serial/8250/8250_dma.c    | 2 +- >  include/linux/dmaengine.h             | 4 ++-- >  sound/soc/soc-generic-dmaengine-pcm.c | 2 +- >  4 files changed, 8 insertions(+), 8 deletions(-) > -- Andy Shevchenko Intel Finland Oy