From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932596AbcEFSHD (ORCPT ); Fri, 6 May 2016 14:07:03 -0400 Received: from mga01.intel.com ([192.55.52.88]:6648 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932129AbcEFSG7 (ORCPT ); Fri, 6 May 2016 14:06:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,587,1455004800"; d="scan'208";a="947793682" Message-ID: <1462558083.17131.287.camel@linux.intel.com> Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface From: Andy Shevchenko To: Maarten Brock , Andy Shevchenko Cc: "Bryan O'Donoghue" , Peter Hurley , linux-serial@vger.kernel.org, Vinod Koul , linux-kernel@vger.kernel.org, dmaengine , Greg Kroah-Hartman , "Puustinen, Ismo" , Heikki Krogerus Date: Fri, 06 May 2016 21:08:03 +0300 In-Reply-To: <20160506174805.61f64dba@kerio.vanmierlo.com> References: <20160506174805.61f64dba@kerio.vanmierlo.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-05-06 at 17:48 +0200, Maarten Brock wrote: > +       bool                    polarity; > > > > > So this variable is not very intuitively named. > > > > There is a help above. This is a property of the Synopsys > > > > DesignWare DMA > > > > engine. Anyone familiar with datasheet easily understands this. > > > > > > > > > > > > > > > > > > > You end up setting somepointer->polarity = true; in a later > > > > > patch. > > > > > > > > > > Since you're respining a V4 I'd suggest a name that describes > > > > > a little > > > > > bit better than polarity. Setting polarity = true is a little > > > > > bit > > > > > liked being asked "you you like ice-cream or apple pie" and > > > > > then > > > > > saying "yes please". > > > > It's about handshake interface polarity, so, what about > > > > hs_polarity? > > > So it means: handshake has polarity (true) or handshake has no > > > polarity > > > (omnidirectional?) (false), right? > > It means that handshake polarity _signal_ is inverted (true) or > > default (false) in terms of hardware gates. > Would it not be better then to name it handshake_inverted ? That is > something you can ask and answer with true or false. > I would stick for now with hs_polarity as agreed with Bryan. Without specification any (more or less short) name will suck anyway. -- Andy Shevchenko Intel Finland Oy