From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758665AbcEFSeH (ORCPT ); Fri, 6 May 2016 14:34:07 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:32989 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1758224AbcEFSeF (ORCPT ); Fri, 6 May 2016 14:34:05 -0400 Message-ID: <1462559636.11805.6.camel@mtksdaap41> Subject: Re: [alsa-devel] [PATCH 1/7] ASoC: mediatek: Refine mt8173 driver and change config option From: Garlic Tseng To: Mark Brown CC: Matthias Brugger , , , , , , , , , Date: Sat, 7 May 2016 02:33:56 +0800 In-Reply-To: <20160506122046.GR6292@sirena.org.uk> References: <1461934848-60011-1-git-send-email-garlic.tseng@mediatek.com> <1461934848-60011-2-git-send-email-garlic.tseng@mediatek.com> <20160504164306.GA6292@sirena.org.uk> <1462416342.25179.36.camel@mtksdaap41> <572B0511.80701@gmail.com> <1462444772.2873.70.camel@mtksdaap41> <20160506122046.GR6292@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-05-06 at 13:20 +0100, Mark Brown wrote: > On Thu, May 05, 2016 at 06:39:32PM +0800, Garlic Tseng wrote: > > > As mentioned above, the difference of the ASoCs between the two chips > > are too large that we have a hard time sharing the driver code. > > The things you're describing all sound like scaling differences rather > than fundamental changes. I'd expect to see at least some shared code > here, we don't want to be just duplicating the entire driver every time > there's a new hardware revision. Oh ok, I'll do it in the next version. Thanks for comment.