From: Bruno Carvalho <brunocarvalhofarias@gmail.com>
To: gregkh@linuxfoundation.org
Cc: ciorneiioana@gmail.com, amitoj1606@gmail.com,
s.demeszko@wireless-instruments.com, shraddha.6596@gmail.com,
bhumirks@gmail.com, shivanib134@gmail.com,
mahfouz.saif.elyazal@gmail.com, tj@kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Bruno Carvalho <brunocarvalhofarias@gmail.com>
Subject: [PATCH] staging: gdm724x: fixing coding style problems listed by checkpatch
Date: Fri, 6 May 2016 18:46:32 -0400 [thread overview]
Message-ID: <1462574792-4672-1-git-send-email-brunocarvalhofarias@gmail.com> (raw)
This patch is to fix some coding style issues pointed
by scripts/checkpatch.pl
Signed-off-by: Bruno Carvalho <brunocarvalhofarias@gmail.com>
---
drivers/staging/gdm724x/gdm_mux.c | 6 ++++--
drivers/staging/gdm724x/gdm_mux.h | 12 ++++++------
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index 6bedd66..5e661d9 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -278,8 +278,10 @@ static void gdm_mux_rcv_complete(struct urb *urb)
}
}
-static int gdm_mux_recv(void *priv_dev, int (*cb)(void *data, int len,
- int tty_index, struct tty_dev *tty_dev, int complete))
+static int gdm_mux_recv(void *priv_dev,
+ int (*cb)(void *data, int len,
+ int tty_index,
+ struct tty_dev *tty_dev, int complete))
{
struct mux_dev *mux_dev = priv_dev;
struct usb_device *usbdev = mux_dev->usbdev;
diff --git a/drivers/staging/gdm724x/gdm_mux.h b/drivers/staging/gdm724x/gdm_mux.h
index 3d50383..49bb90d 100644
--- a/drivers/staging/gdm724x/gdm_mux.h
+++ b/drivers/staging/gdm724x/gdm_mux.h
@@ -27,8 +27,8 @@
#define START_FLAG 0xA512485A
#define MUX_HEADER_SIZE 14
-#define MUX_TX_MAX_SIZE (1024*10)
-#define MUX_RX_MAX_SIZE (1024*30)
+#define MUX_TX_MAX_SIZE (1024 * 10)
+#define MUX_RX_MAX_SIZE (1024 * 30)
#define AT_PKT_TYPE 0xF011
#define DM_PKT_TYPE 0xF010
@@ -70,9 +70,9 @@ struct rx_cxt {
struct list_head to_host_list;
struct list_head rx_submit_list;
struct list_head rx_free_list;
- spinlock_t to_host_lock;
- spinlock_t submit_list_lock;
- spinlock_t free_list_lock;
+ spinlock_t to_host_lock; /* spinlock for host handling */
+ spinlock_t submit_list_lock; /* spinlock for submit list handling */
+ spinlock_t free_list_lock; /* spinlock for free list handling */
};
struct mux_dev {
@@ -88,7 +88,7 @@ struct mux_dev {
int tty_index,
struct tty_dev *tty_dev,
int complete);
- spinlock_t write_lock;
+ spinlock_t write_lock; /* spinlock for write handling */
struct tty_dev *tty_dev;
};
--
2.1.4
next reply other threads:[~2016-05-06 22:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 22:46 Bruno Carvalho [this message]
2016-05-07 3:29 ` [PATCH] staging: gdm724x: fixing coding style problems listed by checkpatch Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462574792-4672-1-git-send-email-brunocarvalhofarias@gmail.com \
--to=brunocarvalhofarias@gmail.com \
--cc=amitoj1606@gmail.com \
--cc=bhumirks@gmail.com \
--cc=ciorneiioana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=s.demeszko@wireless-instruments.com \
--cc=shivanib134@gmail.com \
--cc=shraddha.6596@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox