[PATCH v2 1/1] Staging: android: uapi: ion: Fixes indentation

[PATCH v2 1/1] Staging: android: uapi: ion: Fixes indentation

[Thimo Braker]

Fixes the indentation before variable names.

Signed-off-by: Thimo Braker <thibmorozier@gmail.com>
---
 drivers/staging/android/uapi/ion.h      | 20 ++++++++++----------
 drivers/staging/android/uapi/ion_test.h | 10 +++++-----
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 0a8e40f..6dda8d5 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -91,11 +91,11 @@ enum ion_heap_type {
  * Provided by userspace as an argument to the ioctl
  */
 struct ion_allocation_data {
-	size_t len;
-	size_t align;
-	unsigned int heap_id_mask;
-	unsigned int flags;
-	ion_user_handle_t handle;
+	size_t			len;
+	size_t			align;
+	unsigned int		heap_id_mask;
+	unsigned int		flags;
+	ion_user_handle_t	handle;
 };
 
 /**
@@ -109,8 +109,8 @@ struct ion_allocation_data {
  * provides the file descriptor and the kernel returns the handle.
  */
 struct ion_fd_data {
-	ion_user_handle_t handle;
-	int fd;
+	ion_user_handle_t	handle;
+	int			fd;
 };
 
 /**
@@ -118,7 +118,7 @@ struct ion_fd_data {
  * @handle:	a handle
  */
 struct ion_handle_data {
-	ion_user_handle_t handle;
+	ion_user_handle_t	handle;
 };
 
 /**
@@ -130,8 +130,8 @@ struct ion_handle_data {
  * This works just like the regular cmd and arg fields of an ioctl.
  */
 struct ion_custom_data {
-	unsigned int cmd;
-	unsigned long arg;
+	unsigned int	cmd;
+	unsigned long	arg;
 };
 
 #define ION_IOC_MAGIC		'I'
diff --git a/drivers/staging/android/uapi/ion_test.h b/drivers/staging/android/uapi/ion_test.h
index ffef06f..0d5a496 100644
--- a/drivers/staging/android/uapi/ion_test.h
+++ b/drivers/staging/android/uapi/ion_test.h
@@ -28,11 +28,11 @@
  * @write:	1 to write, 0 to read
  */
 struct ion_test_rw_data {
-	__u64 ptr;
-	__u64 offset;
-	__u64 size;
-	int write;
-	int __padding;
+	__u64	ptr;
+	__u64	offset;
+	__u64	size;
+	int	write;
+	int	__padding;
 };
 
 #define ION_IOC_MAGIC		'I'
-- 
2.1.4

Re: [PATCH v2 1/1] Staging: android: uapi: ion: Fixes indentation

[Greg KH]

On Sun, May 08, 2016 at 01:41:47PM +0200, Thimo Braker wrote:
> Fixes the indentation before variable names.
> 
> Signed-off-by: Thimo Braker <thibmorozier@gmail.com>
> ---
>  drivers/staging/android/uapi/ion.h      | 20 ++++++++++----------
>  drivers/staging/android/uapi/ion_test.h | 10 +++++-----
>  2 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 0a8e40f..6dda8d5 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -91,11 +91,11 @@ enum ion_heap_type {
>   * Provided by userspace as an argument to the ioctl
>   */
>  struct ion_allocation_data {
> -	size_t len;
> -	size_t align;
> -	unsigned int heap_id_mask;
> -	unsigned int flags;
> -	ion_user_handle_t handle;
> +	size_t			len;
> +	size_t			align;
> +	unsigned int		heap_id_mask;
> +	unsigned int		flags;
> +	ion_user_handle_t	handle;

Hm, that's not really a "fix" anywhere.  There's no kernel rule that you
have to align the fields in a structure.

What "tool" told you this was necessary?

So this patch isn't needed, sorry.

thanks,

greg k-h