Re: [PATCH v5 07/12] zsmalloc: factor page chain functionality out

Sergey Senozhatsky
2016-05-16T02:14:30Z

On (05/09/16 11:20), Minchan Kim wrote:
> For page migration, we need to create page chain of zspage dynamically
> so this patch factors it out from alloc_zspage.
>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

[..]
> + page = alloc_page(flags);
> + if (!page) {
> + while (--i >= 0)
> + __free_page(pages[i]);

put_page() ?

a minor nit, put_page() here probably will be in alignment
with __free_zspage(), which does put_page().

-ss

> + return NULL;
> + }
> + pages[i] = page;
> }
>
> + create_page_chain(pages, class->pages_per_zspage);
> + first_page = pages[0];
> + init_zspage(class, first_page);
> +
> return first_page;
> }