From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbcEJHmc (ORCPT ); Tue, 10 May 2016 03:42:32 -0400 Received: from szxga04-in.huawei.com ([58.251.152.52]:1360 "EHLO szxga04-in.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751335AbcEJHlZ (ORCPT ); Tue, 10 May 2016 03:41:25 -0400 From: He Kuang To: , , , , , , , , , , , , , , , , , CC: Subject: [PATCH v2 1/9] perf tools: Omit DWARF judgement when recording dwarf callchain Date: Tue, 10 May 2016 07:40:29 +0000 Message-ID: <1462866037-30382-2-git-send-email-hekuang@huawei.com> X-Mailer: git-send-email 1.8.3.4 In-Reply-To: <1462866037-30382-1-git-send-email-hekuang@huawei.com> References: <1462866037-30382-1-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.193.250] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.57319084.00D4,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 988cec31f1cb8f032d983e5e9179e74d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to check for DWARF unwinding support when using the 'dwarf' callchain record method, as this will only ask the kernel to collect stack dumps for later DWARF CFI processing, which can be done in another machine, where the support for DWARF unwinding need to be present. Signed-off-by: He Kuang Acked-by: Jiri Olsa --- tools/perf/util/util.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c index b7766c5..e5ebfd4 100644 --- a/tools/perf/util/util.c +++ b/tools/perf/util/util.c @@ -471,7 +471,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param) "needed for --call-graph fp\n"); break; -#ifdef HAVE_DWARF_UNWIND_SUPPORT /* Dwarf style */ } else if (!strncmp(name, "dwarf", sizeof("dwarf"))) { const unsigned long default_stack_dump_size = 8192; @@ -487,7 +486,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param) ret = get_stack_size(tok, &size); param->dump_size = size; } -#endif /* HAVE_DWARF_UNWIND_SUPPORT */ } else if (!strncmp(name, "lbr", sizeof("lbr"))) { if (!strtok_r(NULL, ",", &saveptr)) { param->record_mode = CALLCHAIN_LBR; -- 1.8.5.2