From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932377AbcEKOeQ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 May 2016 10:34:16 -0400
Received: from g1t5425.austin.hp.com ([15.216.225.55]:54700 "EHLO
	g1t5425.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751594AbcEKOeO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 May 2016 10:34:14 -0400
Message-ID: <1462976710.27137.140.camel@hpe.com>
Subject: Re: [PATCH v4 6/6] block: Update blkdev_dax_capable() for
 consistency
From: Toshi Kani <toshi.kani@hpe.com>
To: Jan Kara <jack@suse.cz>
Cc: dan.j.williams@intel.com, david@fromorbit.com, viro@zeniv.linux.org.uk,
        axboe@fb.com, hch@infradead.org, boaz@plexistor.com, tytso@mit.edu,
        adilger.kernel@dilger.ca, ross.zwisler@linux.intel.com,
        micah.parrish@hpe.com, linux-nvdimm@ml01.01.org,
        linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Wed, 11 May 2016 08:25:10 -0600
In-Reply-To: <20160511080537.GA14744@quack2.suse.cz>
References: <1462897437-16626-1-git-send-email-toshi.kani@hpe.com>
	 <1462897437-16626-7-git-send-email-toshi.kani@hpe.com>
	 <20160511080537.GA14744@quack2.suse.cz>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-05-11 at 10:05 +0200, Jan Kara wrote:
> On Tue 10-05-16 10:23:57, Toshi Kani wrote:
> > 
> > blkdev_dax_capable() is similar to bdev_dax_supported(), but needs
> > to remain as a separate interface for checking dax capability of
> > a raw block device.
> > 
> > Rename and relocate blkdev_dax_capable() to keep them maintained
> > consistently, and call bdev_direct_access() for the dax capability
> > check.
> ...
> > 
> > +bool bdev_dax_capable(struct block_device *bdev)
> > +{
> > +	struct gendisk *disk = bdev->bd_disk;
> > +	struct blk_dax_ctl dax = {
> > +		.size = PAGE_SIZE,
> > +	};
> > +
> > +	if (!IS_ENABLED(CONFIG_FS_DAX))
> > +		return false;
>
> Frankly, I prefer the #ifdef CONFIG_FS_DAX and just compile the code out
> when DAX is not enabled (like it was with blkdev_dax_capable()). That way
> we don't grow the kernel for people who don't care about DAX.

When CONFIG_FS_DAX is not set, the rest of the code is optimized out.  So,
I think the code size is the same.

(gdb) disas bdev_dax_capable
Dump of assembler code for function bdev_dax_capable:
   0xffffffff81260d20 <+0>:     callq  0xffffffff81813c30 <__fentry__>
   0xffffffff81260d25 <+5>:     push   %rbp
   0xffffffff81260d26 <+6>:     xor    %eax,%eax
   0xffffffff81260d28 <+8>:     mov    %rsp,%rbp
   0xffffffff81260d2b <+11>:    pop    %rbp
   0xffffffff81260d2c <+12>:    retq   
End of assembler dump.

Thanks,
-Toshi