From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932210AbcEKTKX (ORCPT ); Wed, 11 May 2016 15:10:23 -0400 Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:58390 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932072AbcEKTKW (ORCPT ); Wed, 11 May 2016 15:10:22 -0400 Message-ID: <1462993816.7800.17.camel@tiscali.nl> Subject: Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline From: Paul Bolle To: Daniel Vetter , Noralf =?ISO-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Wed, 11 May 2016 21:10:16 +0200 In-Reply-To: <20160511170910.GU27098@phenom.ffwll.local> References: <1462982962-10530-1-git-send-email-noralf@tronnes.org> <1462982962-10530-7-git-send-email-noralf@tronnes.org> <20160511170910.GU27098@phenom.ffwll.local> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On wo, 2016-05-11 at 19:09 +0200, Daniel Vetter wrote: > On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > +config DRM_SIMPLE_KMS_HELPER > > + tristate > > + depends on DRM > > + select DRM_KMS_HELPER > > + help > > + Helpers for very simple KMS drivers. > > Personally not sold on piles of Kconfig knobs for tiny amounts of code > like this one. I'd just drop it. For a more elaborate argument see > http://sietch-tagr.blogspot.ch/2016/04/display-panels-are-not-special.html > > Note that almost all the other helpers do not have a Kconfig option, the > only real exception is the fbdev helpers. And those have a good reason: > They'd drag in all of fbdev, and that is actually a pile of code. Moreover, this adds a kconfig entry without a prompt. The entry also doesn't have a "default". And I didn't spot a patch adding a select for this symbol. So, based on just this series, I think that DRM_SIMPLE_KMS_HELPER can't actually be set. I didn't test this, so perhaps I missed something. Did I, Noralf? Paul Bolle