Re: [PATCH v5 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark

Andy Shevchenko
2016-05-12T15:05:46Z

On Fri, 2016-05-06 at 18:17 +0300, Andy Shevchenko wrote:
> This is combined series of two things:
> - split out the Intel LPSS specific driver from 8250_pci into
> 8250_lpss
> - enable DMA support on Intel Quark UART
>
> The patch has been tested on few Intel SoCs / platforms. In any case I
> would
> like to ask Bryan to do independent test.
>
> This is targeting serial subsystem, thus it would be nice to get and
> Ack from
> Vinod first. Moreover, the series depends on [1] that is now in
> Vinod's
> slave-dma tree.
>
> That's why I asked Vinod to create immutable tag / branch for the [1]
> and the
> dependants (at least one more, which is sata_dwc_460ex) can use it.
>
> The series can be reached in the branch located at [2].
>
> [1] http://www.spinics.net/lists/kernel/msg2244475.html
> [2] https://bitbucket.org/andy-shev/linux/branch/topic%2Fdw%2Fqrk
>

Do we have a chance to get this? Requirement, i.e. topic/dw branch of
Vinod's slave-dma tree is available and has all prerequisites.

> Since v4:
> - fix an issue what kernel test bot reported (lkp)
> - add a list of supported SoC to Kconfig (Bryan)
> - rename polarity -> hs_polarity (Bryan)
>
> Since v3:
> - rebase on top of recent tty-next branch
> - add Reviewed-by tag from Bryan
>
> Since v2:
> - add tags
> - rebase on top of new version of [1]
>
> Since v1:
> - address most of Peter's comments (mostly changelog to patch 8)
> - add tag to patch 5
> - drop patch 6 from the series to be separately dealt with
>
> Andy Shevchenko (11):
>   dmaengine: dw: keep copy of custom slave config in dwc
>   dmaengine: dw: provide probe(), remove() stubs for users
>   dmaengine: dw: set polarity of handshake interface
>   dmaengine: dw: override LLP support if asked in platform data
>   serial: 8250_dma: switch to new dmaengine_terminate_* API
>   serial: 8250_dma: adjust DMA address of the UART
>   serial: 8250: enable AFE on ports where FIFO is 16 bytes
>   serial: 8250_lpss: split LPSS driver to separate module
>   serial: 8250_lpss: move Quark code from PCI driver
>   serial: 8250_lpss: enable MSI for Intel Quark
>   serial: 8250_lpss: enable DMA on Intel Quark UART
>
>  drivers/dma/dw/core.c                |  43 +++--
>  drivers/dma/dw/regs.h                |   5 +-
>  drivers/tty/serial/8250/8250.h       |   5 +
>  drivers/tty/serial/8250/8250_dma.c   |  14 +-
>  drivers/tty/serial/8250/8250_lpss.c  | 357
> +++++++++++++++++++++++++++++++++++
>  drivers/tty/serial/8250/8250_pci.c   | 257 +------------------------
>  drivers/tty/serial/8250/8250_port.c  |   9 +-
>  drivers/tty/serial/8250/Kconfig      |  16 +-
>  drivers/tty/serial/8250/Makefile     |   1 +
>  include/linux/dma/dw.h               |   5 +
>  include/linux/platform_data/dma-dw.h |   4 +
>  11 files changed, 430 insertions(+), 286 deletions(-)
>  create mode 100644 drivers/tty/serial/8250/8250_lpss.c
>

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy