From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Meelis Roos <mroos@linux.ee>,
linux-scsi@vger.kernel.org,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Hannes Reinecke <hare@suse.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: UBSAN: Undefined behaviour in drivers/scsi/aic7xxx/aic7xxx_core.c:2831:31
Date: Thu, 12 May 2016 13:08:30 -0700 [thread overview]
Message-ID: <1463083710.2380.46.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.LRH.2.20.1605121859240.4797@math.ut.ee>
On Thu, 2016-05-12 at 19:02 +0300, Meelis Roos wrote:
> This is from a dual-AthlonMP 32-bit x86 system with onboard Adaptec
> SCSI
> controller, once during bootup.
>
> [ 4.896307]
> =====================================================================
> ===========
> [ 4.896471] UBSAN: Undefined behaviour in
> drivers/scsi/aic7xxx/aic7xxx_core.c:2831:31
> [ 4.896629] shift exponent -1 is negative
Is this some sort of false positive? The shift in question is
devinfo->target_mask = (0x01 << devinfo->target_offset);
The code which calls this in ahc_linux_initialize_scsi_bus() looks to
be looping from 0-16 (or variations). Since the value passed in is
unsigned, it would have to be set to ~0, which doesn't seem possible.
James
next prev parent reply other threads:[~2016-05-12 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 16:02 UBSAN: Undefined behaviour in drivers/scsi/aic7xxx/aic7xxx_core.c:2831:31 Meelis Roos
2016-05-12 20:08 ` James Bottomley [this message]
2016-05-12 21:56 ` Ilia Mirkin
2016-05-13 5:26 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463083710.2380.46.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=hare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox