From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932333AbcEMNLN (ORCPT ); Fri, 13 May 2016 09:11:13 -0400 Received: from mga03.intel.com ([134.134.136.65]:8385 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932119AbcEMNLK (ORCPT ); Fri, 13 May 2016 09:11:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,614,1455004800"; d="scan'208";a="702251533" Message-ID: <1463145136.17131.344.camel@linux.intel.com> Subject: Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi From: Andy Shevchenko To: Yisen Zhuang , davem@davemloft.net, rjw@rjwysocki.net, lenb@kernel.org Cc: arnd@arndb.de, andrew@lunn.ch, geliangtang@163.com, ivecera@redhat.com, fengguang.wu@intel.com, charles.chenxin@huawei.com, haifeng.wei@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Date: Fri, 13 May 2016 16:12:16 +0300 In-Reply-To: <1463127557-90824-8-git-send-email-Yisen.Zhuang@huawei.com> References: <1463127557-90824-1-git-send-email-Yisen.Zhuang@huawei.com> <1463127557-90824-8-git-send-email-Yisen.Zhuang@huawei.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote: > From: Kejian Yan > > Dsaf needs to get configuration parameter by ACPI, so this patch add > support of ACPI. > Looks like at some point better to split driver to core part, and PCI and ACPI/DT/platform code. Too many changes where IS_ENABLED() involved shows as I can imagine bad architecture / split of the driver. -- Andy Shevchenko Intel Finland Oy