From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752804AbcEMNOJ (ORCPT ); Fri, 13 May 2016 09:14:09 -0400 Received: from mga02.intel.com ([134.134.136.20]:37278 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbcEMNOH (ORCPT ); Fri, 13 May 2016 09:14:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,614,1455004800"; d="scan'208";a="953174645" Message-ID: <1463145312.17131.347.camel@linux.intel.com> Subject: Re: [patch net-next 06/11] ACPI: bus: move acpi_match_device_ids() to linux/acpi.h From: Andy Shevchenko To: Yisen Zhuang , davem@davemloft.net, rjw@rjwysocki.net, lenb@kernel.org Cc: arnd@arndb.de, andrew@lunn.ch, geliangtang@163.com, ivecera@redhat.com, fengguang.wu@intel.com, charles.chenxin@huawei.com, haifeng.wei@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Date: Fri, 13 May 2016 16:15:12 +0300 In-Reply-To: <1463127557-90824-7-git-send-email-Yisen.Zhuang@huawei.com> References: <1463127557-90824-1-git-send-email-Yisen.Zhuang@huawei.com> <1463127557-90824-7-git-send-email-Yisen.Zhuang@huawei.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote: > From: Hanjun Guo > > acpi_match_device_ids() will be used for drivers to match > different hardware versions, it will be compiled in non-ACPI > case, but acpi_match_device_ids() in acpi_bus.h and it can > only be used in ACPI case, so move it to linux/acpi.h and > introduce a stub function for it. I somehow doubt this is right move. Like I said in the previous comment the architectural split might make this a bit better. You might use  #ifdef IS_ENABLED(CONFIG_ACPI) #else #endif only once to some big part of code. If kernel is build without ACPI support you even will not have this in your driver at all. --  Andy Shevchenko Intel Finland Oy