From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751417AbcEQRHn (ORCPT ); Tue, 17 May 2016 13:07:43 -0400 Received: from g2t4618.austin.hp.com ([15.73.212.83]:37809 "EHLO g2t4618.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbcEQRHl (ORCPT ); Tue, 17 May 2016 13:07:41 -0400 X-Greylist: delayed 58917 seconds by postgrey-1.27 at vger.kernel.org; Tue, 17 May 2016 13:07:41 EDT Message-ID: <1463504804.14655.9.camel@j-VirtualBox> Subject: Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t From: Jason Low To: Peter Zijlstra Cc: jason.low2@hp.com, Linus Torvalds , Ingo Molnar , Linux Kernel Mailing List , Andrew Morton , Richard Henderson , Ivan Kokshaysky , Matt Turner , Tony Luck , Fenghua Yu , Martin Schwidefsky , Terry Rudd , Heiko Carstens , Thomas Gleixner , Arnd Bergmann , Christoph Lameter , Davidlohr Bueso , Waiman Long , Tim Chen , Peter Hurley Date: Tue, 17 May 2016 10:06:44 -0700 In-Reply-To: <20160517110906.GW3193@twins.programming.kicks-ass.net> References: <1463445486-16078-1-git-send-email-jason.low2@hpe.com> <20160517110906.GW3193@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-05-17 at 13:09 +0200, Peter Zijlstra wrote: > On Mon, May 16, 2016 at 06:12:25PM -0700, Linus Torvalds wrote: > > On Mon, May 16, 2016 at 5:37 PM, Jason Low wrote: > > > > > > This rest of the series converts the rwsem count variable to an atomic_long_t > > > since it is used it as an atomic variable. This allows us to also remove > > > the rwsem_atomic_{add,update} abstraction and reduce 100+ lines of code. > > > > I would suggest you merge all the "remove rwsem_atomic_{add,update}" > > patches into a single patch. > > > > I don't see the advantage to splitting those up by architecture, and > > it does add noise to the series. > > > > Other than that it all looks fine to me. > > OK, done. Right, they all fit under the same category of "Removing rwsem_atomic_{add,update}", so it makes sense to fold them into one patch. Thanks, Jason