From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752006AbcERHTM (ORCPT ); Wed, 18 May 2016 03:19:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:48366 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbcERHTK (ORCPT ); Wed, 18 May 2016 03:19:10 -0400 Message-ID: <1463555740.22748.0.camel@suse.com> Subject: Re: [1/1] net: pegasus: remove dead coding From: Oliver Neukum To: Guenter Roeck Cc: Heinrich Schuchardt , Petko Manolov , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Date: Wed, 18 May 2016 09:15:40 +0200 In-Reply-To: <20160518063024.GA29326@roeck-us.net> References: <1463530410-12772-1-git-send-email-xypron.glpk@gmx.de> <20160518063024.GA29326@roeck-us.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-05-17 at 23:30 -0700, Guenter Roeck wrote: > On Wed, May 18, 2016 at 02:13:30AM +0200, Heinrich Schuchardt wrote: > > (!count || count < 4) is always true. > > Even if count >= 4 ? The check for !count is redundant, though. Gcc, however, will surely simplify the expression. Regards Oliver