From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755132AbcESOwS (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 May 2016 10:52:18 -0400
Received: from mx2.suse.de ([195.135.220.15]:53081 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754391AbcESOwP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 May 2016 10:52:15 -0400
Message-ID: <1463669326.14323.10.camel@suse.com>
Subject: Re: [RFC PATCHv2] usb: USB Type-C Connector Class
From: Oliver Neukum <oneukum@suse.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Rajaram R <rajaram.officemail@gmail.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Date: Thu, 19 May 2016 16:48:46 +0200
In-Reply-To: <1463661894-22820-1-git-send-email-heikki.krogerus@linux.intel.com>
References: <1463661894-22820-1-git-send-email-heikki.krogerus@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote:

> +	dev->class = &typec_class;
> +	dev->parent = parent;
> +	dev->type = &typec_partner_dev_type;
> +	dev_set_name(dev, "%s-partner", dev_name(&port->dev));
> +
> +	ret = device_register(dev);
> +	if (ret) {
> +		put_device(dev);
> +		return ret;
> +	}

This looks like a race condition.

> +	ret = typec_register_altmodes(dev, partner->alt_modes);
> +	if (ret) {
> +		device_unregister(dev);
> +		return ret;
> +	}
> +
> +	/* REVISIT: Creating symlink for the port device for now. */
> +	ret = sysfs_create_link(&port->dev.kobj, &dev->kobj, "partner");
> +	if (ret)
> +		dev_WARN(&port->dev, "failed to create link to %s (%d)\n",
> +			 dev_name(dev), ret);

The attributes should be present as soon as the device is announced.

	Regards
		Oliver