From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756096AbcETPXL (ORCPT ); Fri, 20 May 2016 11:23:11 -0400 Received: from mail-bl2on0119.outbound.protection.outlook.com ([65.55.169.119]:62438 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752516AbcETPXH (ORCPT ); Fri, 20 May 2016 11:23:07 -0400 From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" , "viro@zeniv.linux.org.uk" , "jack@suse.cz" , "david@fromorbit.com" , "sandeen@sandeen.net" , "vishal.l.verma@intel.com" CC: "Parrish, Micah (HP Servers Linux R&D)" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "axboe@fb.com" , "linux-nvdimm@lists.01.org" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "tytso@mit.edu" , "boaz@plexistor.com" Subject: Re: [PATCH v4 0/6] Add alignment check for DAX mount Thread-Topic: [PATCH v4 0/6] Add alignment check for DAX mount Thread-Index: AQHRqtmdl2O2OiZJoEGBQEuUkn6SYJ/A+QgAgAD8gYA= Date: Fri, 20 May 2016 14:50:05 +0000 Message-ID: <1463755257.32042.15.camel@hpe.com> References: <1462897437-16626-1-git-send-email-toshi.kani@hpe.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: 1405dee4-494f-465b-d5ee-08d380be07d2 x-microsoft-exchange-diagnostics: 1;CS1PR84MB0102;5:Ppc3brOIBycQsylXxkanPXgR1NvzTX5eo0UifpUADeYhF9Txk9MYOWTbGiAgGRKrKwTEbWo3SPk7WIaR1CFjzalr3zHilX9EJmgCVDgXq1wJkxyY33Ie+cdqxm5KfHgO1XbHl4V6ZMQvpRXDRdO3Fg==;24:2CAETh4zc5M+rExKXL4Hpo8VAUZFjupZmxa+Pct2cW+S1fNi9Iou3jRuhhVAdhlKBM9111WoEt2ljCgucEUeyhs+OKcqvvdYPC/OEDe0qOk=;7:u4k3h2YjmYeo0Jcl5qD6iR5Uv15gshF0z28Wg0Fi6q2a6HFYb8RJalR9PRiJKnsFTunLbYQL/Atr8rKNGbMcHM4AR2CXws3VKJ7Fbv+d5Q8wRomqb5evcUKissjIOeX5lNHTNyuXSoeyH5EP8orM5RXfmv2rVQk0Q+3zndz/kbRwwQbW0k+JCfcrMlRs5OBB x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0102; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:CS1PR84MB0102;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0102; x-forefront-prvs: 09480768F8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(377454003)(24454002)(99286002)(36756003)(10400500002)(2950100001)(77096005)(2900100001)(86362001)(66066001)(2906002)(106116001)(11100500001)(4326007)(92566002)(8936002)(5002640100001)(3846002)(8676002)(189998001)(81166006)(3660700001)(5001770100001)(586003)(5008740100001)(33646002)(2501003)(6116002)(122556002)(103116003)(76176999)(3280700002)(1220700001)(5004730100002)(54356999)(102836003)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0102;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <773678FCC3FAD347868F4644E1224647@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2016 14:50:05.1208 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0102 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u4KFNGHx009262 On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote: > On 5/10/16 11:23 AM, Toshi Kani wrote: > > > > When a partition is not aligned by 4KB, mount -o dax succeeds, > > Sorry for being late, but - > > Shouldn't this and all subsequent patch commits refer to > PAGE_SIZE, rather than "4kB?" Right, the patch commits should refer to PAGE_SIZE to match with the code changes.  I am afraid it may be a bit too late to update, though... Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"? Thanks, -Toshi