From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756211AbcETPsa (ORCPT ); Fri, 20 May 2016 11:48:30 -0400 Received: from mail-bn1bon0148.outbound.protection.outlook.com ([157.56.111.148]:47808 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754462AbcETPs2 (ORCPT ); Fri, 20 May 2016 11:48:28 -0400 X-Greylist: delayed 3499 seconds by postgrey-1.27 at vger.kernel.org; Fri, 20 May 2016 11:48:27 EDT From: "Kani, Toshimitsu" To: "lkp@intel.com" , "arnd@arndb.de" CC: "Parrish, Micah (HP Servers Linux R&D)" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "viro@zeniv.linux.org.uk" , "dan.j.williams@intel.com" , "axboe@fb.com" , "linux-nvdimm@lists.01.org" , "kbuild-all@01.org" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "tytso@mit.edu" , "boaz@plexistor.com" , "david@fromorbit.com" , "jack@suse.cz" Subject: Re: [PATCH] remove unused blkdev_dax_capable() function Thread-Topic: [PATCH] remove unused blkdev_dax_capable() function Thread-Index: AQHRsNqAmXc8Czduckevs8JEbWa6Hp/BtN4AgABE8YA= Date: Fri, 20 May 2016 15:48:23 +0000 Message-ID: <1463758753.32042.26.camel@hpe.com> References: <201605201900.FlOCWSKP%fengguang.wu@intel.com> In-Reply-To: <201605201900.FlOCWSKP%fengguang.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: 625959cb-bdd6-4797-a09c-08d380c62cdd x-microsoft-exchange-diagnostics: 1;CS1PR84MB0008;5:Wl08Tc8Kh5ndwDVY+ZYbTOhLj6iGxePWSaExujTWUBhymytibYLDmgWchoiUiRawmCWbpzvuzNtmDZdrrIf6MCW3+0HSRS5rrOXhNuLH9Bc+rXSGWJGLMwhVwvfZ2x3PLxOrt7wHfmXsmNFZ7Iu0jA==;24:Nop1POQOtckEtPXddt7EPjYymO05ytu6hVlUK07f+uvOAPdDsQ9uoS6zXTtZUV8A5acEyp2k4BVQ01/QmnmJiBrzVfCjWeFciRUMJkc1JWw=;7:evxCQ9JvjwC+HtHfQYNPEMOruvAxrCR0EP7WHXzF5AjR/bywSRCh4N4NoTov/DeyovmWbpXifcA80f/hNR6KeqUNDxT3yk++QruMwCW8KZFps6JVZoLhjsrpOcLl0xc0eznfRmgvuXhwGWvs6i7X5Ad1BOOBUrGw4DWuxw/CLuW+ABq9CMlp88SU2KI+jeFw x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0008; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CS1PR84MB0008;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0008; x-forefront-prvs: 09480768F8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(69234005)(24454002)(1220700001)(19580405001)(189998001)(66066001)(19580395003)(5008740100001)(102836003)(5890100001)(92566002)(6116002)(3660700001)(33646002)(3280700002)(3846002)(2900100001)(54356999)(2950100001)(4001150100001)(2501003)(122556002)(50986999)(86362001)(76176999)(10400500002)(5002640100001)(5004730100002)(586003)(106116001)(2906002)(4326007)(5001770100001)(103116003)(15975445007)(8936002)(8676002)(36756003)(87936001)(77096005)(81166006);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0008;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <350B145B6DF2E044922F97B943D37633@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2016 15:48:23.1786 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0008 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u4KFmao7009377 FYI, fs/block_dev.c has multiple updates since then including the code in question. I just built tot -next m64 kernel with the attached config file, and confirmed no compile error on the file. -Toshi On Fri, 2016-05-20 at 19:32 +0800, kbuild test robot wrote: > Hi, > > [auto build test ERROR on next-20160517] > [cannot apply to v4.6-rc7 v4.6-rc6 v4.6-rc5 v4.6] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url:    https://github.com/0day-ci/linux/commits/Arnd-Bergmann/remove-unu > sed-blkdev_dax_capable-function/20160518-155729 > config: m68k-allyesconfig (attached as .config) > compiler: m68k-linux-gcc (GCC) 4.9.0 > reproduce: >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.g > it/plain/sbin/make.cross -O ~/bin/make.cross >         chmod +x ~/bin/make.cross >         # save the attached .config to linux build tree >         make.cross ARCH=m68k  > > All errors (new ones prefixed by >>): > >    fs/block_dev.c: In function '__blkdev_get': > > > > > > > > fs/block_dev.c:1242:5: error: implicit declaration of function > > > 'blkdev_dax_capable' [-Werror=implicit-function-declaration] >         if (!blkdev_dax_capable(bdev)) >         ^ >    cc1: some warnings being treated as errors > > vim +/blkdev_dax_capable +1242 fs/block_dev.c > > d3374825 NeilBrown    2009-01-09  1236   > goto restart; > d3374825 NeilBrown    2009-01-09  1237   } > 1196f8b8 Tejun Heo    2011-04-21  1238   } > 7e69723f Tejun Heo    2011-05-23  1239   > 5a023cdb Dan Williams 2015-11-30  1240   if (!ret) > { > 7e69723f Tejun Heo    2011-05-23  1241   b > d_set_size(bdev,(loff_t)get_capacity(disk)<<9); > 5a023cdb Dan Williams 2015-11-30 @1242   i > f (!blkdev_dax_capable(bdev)) > 5a023cdb Dan Williams 2015-11-30  1243   > bdev->bd_inode->i_flags &= ~S_DAX; > 5a023cdb Dan Williams 2015-11-30  1244   } > 7e69723f Tejun Heo    2011-05-23  1245   > > :::::: The code at line 1242 was first introduced by commit > :::::: 5a023cdba50c5f5f2bc351783b3131699deb3937 block: enable dax for raw > block devices > > :::::: TO: Dan Williams > :::::: CC: Dan Williams > > --- > 0-DAY kernel test infrastructure                Open Source Technology > Center > https://lists.01.org/pipermail/kbuild-all                   Intel > Corporation