From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751433AbcETRfF (ORCPT ); Fri, 20 May 2016 13:35:05 -0400 Received: from mga01.intel.com ([192.55.52.88]:62109 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbcETRfC (ORCPT ); Fri, 20 May 2016 13:35:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,340,1459839600"; d="scan'208";a="985460115" From: "Verma, Vishal L" To: "Williams, Dan J" , "viro@zeniv.linux.org.uk" , "toshi.kani@hpe.com" , "jack@suse.cz" , "sandeen@sandeen.net" , "david@fromorbit.com" CC: "micah.parrish@hpe.com" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "axboe@fb.com" , "linux-nvdimm@lists.01.org" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "tytso@mit.edu" , "boaz@plexistor.com" Subject: Re: [PATCH v4 0/6] Add alignment check for DAX mount Thread-Topic: [PATCH v4 0/6] Add alignment check for DAX mount Thread-Index: AQHRqtmpiakPEfPMyUe0gEW5nuJiQ5/BbmEAgAD/DoCAAC4PAA== Date: Fri, 20 May 2016 17:34:59 +0000 Message-ID: <1463765696.3005.2.camel@intel.com> References: <1462897437-16626-1-git-send-email-toshi.kani@hpe.com> <1463755257.32042.15.camel@hpe.com> In-Reply-To: <1463755257.32042.15.camel@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.9.103] Content-Type: text/plain; charset="utf-8" Content-ID: <72CEEF3F0DD5A74F901B6D9DBD9FC7D1@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u4KHZB1u009860 On Fri, 2016-05-20 at 14:50 +0000, Kani, Toshimitsu wrote: > On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote: > > > > On 5/10/16 11:23 AM, Toshi Kani wrote: > > > > > > > > > When a partition is not aligned by 4KB, mount -o dax succeeds, > > Sorry for being late, but - > > > > Shouldn't this and all subsequent patch commits refer to > > PAGE_SIZE, rather than "4kB?" > Right, the patch commits should refer to PAGE_SIZE to match with the > code > changes.  I am afraid it may be a bit too late to update, though... > > Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"? > > Thanks, > -Toshi Hi Toshi, Is it just commit message changes? If so I'm not sure it is worthwhile to rebase everything for that - i.e. my dax error handling series and Ross' dax-locking branch would both have to be rebased.. If there are and fixes for code, we can do them as an add-on patch though.