From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbcETRt7 (ORCPT ); Fri, 20 May 2016 13:49:59 -0400 Received: from mail-bn1bon0118.outbound.protection.outlook.com ([157.56.111.118]:56305 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751215AbcETRt4 (ORCPT ); Fri, 20 May 2016 13:49:56 -0400 From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" , "viro@zeniv.linux.org.uk" , "jack@suse.cz" , "david@fromorbit.com" , "sandeen@sandeen.net" , "vishal.l.verma@intel.com" CC: "Parrish, Micah (HP Servers Linux R&D)" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "axboe@fb.com" , "linux-nvdimm@lists.01.org" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "tytso@mit.edu" , "boaz@plexistor.com" Subject: Re: [PATCH v4 0/6] Add alignment check for DAX mount Thread-Topic: [PATCH v4 0/6] Add alignment check for DAX mount Thread-Index: AQHRqtmdl2O2OiZJoEGBQEuUkn6SYJ/A+QgAgAD8gYCAADCggIAAAZkA Date: Fri, 20 May 2016 17:49:51 +0000 Message-ID: <1463766042.32042.34.camel@hpe.com> References: <1462897437-16626-1-git-send-email-toshi.kani@hpe.com> <1463755257.32042.15.camel@hpe.com> <1463765696.3005.2.camel@intel.com> In-Reply-To: <1463765696.3005.2.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: 61da3767-03a8-4e1f-c9ec-08d380d724cf x-microsoft-exchange-diagnostics: 1;CS1PR84MB0007;5:/32ggGDcLgPBmSb3icGeERxriOXydpvlIG1nqrkZOCZshh7dao0VdMNdvnzCgLUPnbdgvDl6ADyPI8kaDr9/JpjnUomew6+i5vI0piiRo07gtMln241GavcKEwOU3dc0WftcaeffUJvo2FhGCiwxoA==;24:x9xLvG0nbga3SuXoTnY2x/RQSLUg26aUbDh5X/jzdFoLIcgbbH6nM164oOQAP7EXySMhwt9QZPVee5zcq0UeOvGToh0qKx7NDHP1GkS0yVw=;7:RxUVbL9H7xv3Mcv1pmEyHcMSBepM6wM/irzdrI2MEL+8I1qpOrIbanH+1k5VEaM3LMf4ODw4kx34s04XS/bnaqR3cSJPa7vlP0JG3X0qK5sNKSmikKg5L0tJDuJEh40POopS9OBepAHkJp5wgqnrKj2/cJX3mrAwe/ak+/6FCkMzZfklj5rs7t/KxdTId2qz x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CS1PR84MB0007;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-forefront-prvs: 09480768F8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(377454003)(24454002)(5004730100002)(92566002)(189998001)(586003)(3846002)(6116002)(106116001)(103116003)(102836003)(122556002)(5001770100001)(3660700001)(3280700002)(77096005)(2501003)(2950100001)(2900100001)(93886004)(8936002)(4326007)(2906002)(1220700001)(5002640100001)(81166006)(54356999)(10400500002)(5008740100001)(8676002)(66066001)(33646002)(2201001)(36756003)(76176999)(86362001)(87936001)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0007;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <7C0572B86745F0408E89AD7E9B9D7224@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2016 17:49:51.1730 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0007 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u4KHo8bX009970 On Fri, 2016-05-20 at 17:34 +0000, Verma, Vishal L wrote: > On Fri, 2016-05-20 at 14:50 +0000, Kani, Toshimitsu wrote: > > On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote: > > > On 5/10/16 11:23 AM, Toshi Kani wrote: > > > >  > > > > When a partition is not aligned by 4KB, mount -o dax succeeds, > > > > > > Sorry for being late, but - > > > > > > Shouldn't this and all subsequent patch commits refer to > > > PAGE_SIZE, rather than "4kB?" > > > > Right, the patch commits should refer to PAGE_SIZE to match with the > > code changes.  I am afraid it may be a bit too late to update, > > though... > > > > Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"? > > > > Thanks, > > -Toshi > > Hi Toshi, > > Is it just commit message changes? If so I'm not sure it is worthwhile > to rebase everything for that - i.e. my dax error handling series and > Ross' dax-locking branch would both have to be rebased.. > > If there are and fixes for code, we can do them as an add-on patch > though. Hi Vishal, Yes, it is just commit messages, and it's OK not to make this change. Thanks, -Toshi