From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754586AbcEXLAj (ORCPT ); Tue, 24 May 2016 07:00:39 -0400 Received: from mail-am1on0108.outbound.protection.outlook.com ([157.56.112.108]:38912 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752545AbcEXLAi (ORCPT ); Tue, 24 May 2016 07:00:38 -0400 Authentication-Results: linux-foundation.org; dkim=none (message not signed) header.d=none;linux-foundation.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Davydov To: Andrew Morton CC: Michal Hocko , Tetsuo Handa , , Subject: [PATCH] mm: oom: do not reap task if there are live threads in threadgroup Date: Tue, 24 May 2016 14:00:28 +0300 Message-ID: <1464087628-7318-1-git-send-email-vdavydov@virtuozzo.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM4PR01CA0001.eurprd01.prod.exchangelabs.com (10.164.74.139) To DB5PR08MB0584.eurprd08.prod.outlook.com (10.169.32.142) X-MS-Office365-Filtering-Correlation-Id: 83b9632f-a158-45f2-ba22-08d383c2a1bf X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0584;2:IRguEFq2WUuX7BFuyTDMaDUrjaDPwQ/nKJJvXmhna5Ks1Rb2PFkgiZDf+xmFykEA38yMQzB0G6M57BDDr9Qk9qziC1rS8KcmQ49DqJjGiL+hCxOUqhYrg7ZV6faCyc6uegvCf1CqO51OfSc9jIF5hspBFquQVf65i9PD3d3cd9nZlFRWgfHccn4rKmdS+S3R;3:W9kq/krgzKiFvJF3YU7NeEtV8HXkRVrOLmcIpfARtUglmRkHS1OnWGslCTcN8aB7zFTvw/h5mkqcpGBW0xzFrDlF0/WgHQkNFP/EJTJutxiTbK/vfvfhB/Kw5lCeEDJd;25:jc/ylpbG8dE+16KAke4t49BGmYQDmB1DTGcj4g2c8MG+WcVZJt7o5K15lJtcjM+rZPD5nti8RYHoBnURhNYSQaCaDag9uqvjEAEa3uwooTjaurmcln/4F0L8QzuGAW3Y/1+j5kcnc3SLs4LqqUsr5+WkEaVMqApjGEC1EZbC6vyA5eqEJNIlsF0i31L5stoQ7pMvObGrt4IGCBeC8+vTPu5nNQza9AZxRjFmsMiomgB8mQ+yzA5WRQ1XBHmKv/Xg9rc5wU+DcovUoRAVWizeAt4DPGAHVHB7LzTOzQPT/WVqfFd8CtW0cYpiAIv7Ox/7WtNpglfYocHaWQCLwCyawyfol1yDqonbMIVpH+WytlmFWZ7rXqf8L6tbkS4WdF8PBmMzBvkndZtoBL2+Ei7GGTZPHgMZXJNX5bUeYMsDcyM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB0584; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041072)(6043046);SRVR:DB5PR08MB0584;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB0584; X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0584;4:HGikOo3B5tgDOcncwy8ISVjDbGPOr9KuaFFlnfOO69OVFgq2eeNTwuqgcVAxpLv5eq67FPeLBITQ+fPMAVvlFgyrnQKnHag3xClFjBcoyJtXyGY5XPcadgURyYSQY6lBc1hh01ZL940zSZjWfcG43SNe3V3g5iEtm1BCXucDQfqae0cNPW6rc+/FfdvafQ1/LluY6ddDkiqHjhOxOLldN+KXLrl00nqN29j+cczek4kboXvMiHzBy5aElctEWT9RpZzwgVl5PuRsrR5R5Wxlengs1AP7q1zjsKGm4ngsS1ZVVdto6ShjTozSuQCYMqhVy98IF3wxtps99hJUPWtunkNhPn+niVDr4daA53H2OB80WG8tPFhxTMrZdTEK5l6BY9XvJOxgOwgUBJ6yx4OMGFim3GsNmQUs9pjMsUhJSd4= X-Forefront-PRVS: 09525C61DB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(50986999)(42186005)(4326007)(2906002)(33646002)(6116002)(586003)(36756003)(86362001)(575784001)(3846002)(92566002)(80792005)(189998001)(110136002)(48376002)(5004730100002)(77096005)(5008740100001)(229853001)(50466002)(5003940100001)(19580395003)(19580405001)(47776003)(66066001)(50226002)(8676002)(81166006);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR08MB0584;H:virtuozzo.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0584;23:4Ol672FDPOEcyhnFVan2UE2z1m227cyd9YF9FK6llEaTxZpUNL+O3b1zoqmhEF3aeWIV3zyY+z/FKDUnj1G2rz3tchLt07TgKKkqel+Ej6xjnsao5KxtMyUagXMbkXPw6xpCJ0EZojNaaF1XmoZ+1Z9yj08jm+qk30T7bQSjtu9rlDijq//hIOXxrmcBJOWUL781h/7RHJz55csR0Hhhul3AZbFT+GmxfgwNAuHcDfL5Mgmp0vPZ68b3vSrKo7c3ThdhBecJkf5DyTvtrCdBiLdYJzkDuCIeRACrnMAXCl6brqUkqxWZ0zCWRTUicI7dsw/w4Dd+jDWMTa9PXmWZPDIYQIF5UrBajJgAfUL7uPaD4ADUnvyNfsUxs7/eK1E1zeKiU5hP9pV85TQEZRu6AZR/Zvvx9Bioch6WCLlAXTnpjkPqz4S7N+0hN4ctUXHbjonJu/N+L+GHLzH+/nLewkCnjxBXfd4smmnXvI/NaTFFRFW7OsvD23v4hCAZ0Th9oScTkdEiPiDGF5JdM2HQ63QD7kI2K5lsbbJractN1sj30Fi9bRe5MCImG4l5LESHbSzW/trcSuEFsrgF2XIBZ388n+GsQDWlIRvfQHFCTvfrMAzYAYUMNSntymiLT10XbyHu/+GQHrFd6eQQYXmJ5tKI6gdXNOIW+Dd+Q/f3eVYsEyVlb5WGCfajxX2N6SDfNNH69bMyeuVVsd3RhxRaTMPbHo4HkA0vdS7p1KwkW2W6VkufWNkyDpOaO+YglDkZKplZOVLu8u9xyQx5COKei44ucBB8EFud1W0cMxtUNOm5ZYufeZqpNuiuF26fPKX1J0jFfQiJNgKU61KOUKDYg/f51Hr8QsApiYgZc6cZqHM= X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0584;5:tNz3JDl+0GULMZERY7qR9BDrA6qSqMwbjD3uTWnF85jfnt0EFiZxGkEtSpgI0SjypOX1RTfUHZ5ocF3SYEMORORDMDdxgYS+71Ta59oK1+8y71jY6wu63I6e1kmrkRG314Tl/ZpNTbKwm9j9TezXIQ==;24:BbPNF7mIH7vKJBXVrvZ/3yAAeN6Sd8ppOg17oBI88mwhmYs7p0H6SlScAv2N5XWvETxhxU9ures6MdQm7A1IVj6ApeQ8H1uHTFM89WJ9TM0=;7:4aKD60tAV0UMKA4/u/RM9y6GonVEh9IPjb842MihzOWEb5E/uCE6jht3Wdf1vBFJmu5O+yKhXX0PXUo0uBmjV1vSTcfc5GjOaejPMRqxEV98xrOzSAEhSXTFlinhf4TkAiAKAbgy/pSIMXNKPTsYqB2V28TsADW0VxcVwsrzcrvBcNYGnWRshSdcLtHn8ndT;20:8wvDLHhHVZw04s5taM9U03HMKhOIRKGtIrYz0dizHKZgJdBt2EAQl35PUYLcL+hD7qKzJsV7vaj8r2v+LeYUruFEI4P3a9lMV/65S7a0MhFrBHI9sknldFsZcpxPr45Id/iH5uzEW4fS08RbN+Lq7euvtIu0AN2FMeV8jGPfno4= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2016 11:00:34.3712 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0584 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the current process is exiting, we don't invoke oom killer, instead we give it access to memory reserves and try to reap its mm in case nobody is going to use it. There's a mistake in the code performing this check - we just ignore any process of the same thread group no matter if it is exiting or not - see try_oom_reaper. Fix it. Signed-off-by: Vladimir Davydov --- mm/oom_kill.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index c0e37dd1422f..03bf7a472296 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -618,8 +618,6 @@ void try_oom_reaper(struct task_struct *tsk) if (!process_shares_mm(p, mm)) continue; - if (same_thread_group(p, tsk)) - continue; if (fatal_signal_pending(p)) continue; -- 2.1.4