public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolai Stange <nicstange@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Nicolai Stange <nicstange@gmail.com>
Subject: [PATCH 0/3] debugfs: fixes to "file removal race" series
Date: Tue, 24 May 2016 13:08:51 +0200	[thread overview]
Message-ID: <1464088134-6001-1-git-send-email-nicstange@gmail.com> (raw)

Hi Greg,

the recent report by Sasha Levin made me review my debugfs
"file removal race" series again.

For your reference, the original series in question was posted here:
http://lkml.kernel.org/g/1458652280-19785-1-git-send-email-nicstange@gmail.com
It has been merged through your driver-core tree into mainline.


Unfortunately, I found three issues:

The first one is a minor code style issue.
The second one is more serious: on ->open() failure, references to modules
as well as memory are leaked.
The third one is a potential leak of module references with future debugfs
users.

The patches don't depend on each other and are unrelated except that they
all address issues introduced by the same series.
I tested them with linux-next 20160523.

Apologies and thanks,

Nicolai

Nicolai Stange (3):
  debugfs: remove extra debugfs_create_file_unsafe() declaration
  debugfs: full_proxy_open(): free proxy on ->open() failure
  debugfs: open_proxy_open(): avoid double fops release

 fs/debugfs/file.c     | 7 ++++---
 fs/debugfs/internal.h | 4 ----
 2 files changed, 4 insertions(+), 7 deletions(-)

-- 
2.8.2

             reply	other threads:[~2016-05-24 11:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 11:08 Nicolai Stange [this message]
2016-05-24 11:08 ` [PATCH 1/3] debugfs: remove extra debugfs_create_file_unsafe() declaration Nicolai Stange
2016-05-24 11:08 ` [PATCH 2/3] debugfs: full_proxy_open(): free proxy on ->open() failure Nicolai Stange
2016-05-24 11:08 ` [PATCH 3/3] debugfs: open_proxy_open(): avoid double fops release Nicolai Stange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464088134-6001-1-git-send-email-nicstange@gmail.com \
    --to=nicstange@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox