From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756154AbcE0Qkl (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 May 2016 12:40:41 -0400
Received: from mga09.intel.com ([134.134.136.24]:10112 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751575AbcE0Qkj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 May 2016 12:40:39 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,374,1459839600"; 
   d="scan'208";a="986026564"
Message-ID: <1464367227.22178.147.camel@linux.intel.com>
Subject: Re: [PATCH 1/7] mm: Cleanup - Reorganize the shrink_page_list code
 into smaller functions
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: "Kirill A.Shutemov" <kirill.shutemov@linux.intel.com>,
        Andi Kleen <andi@firstfloor.org>, Aaron Lu <aaron.lu@intel.com>,
        Huang Ying <ying.huang@intel.com>, linux-mm <linux-mm@kvack.org>,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Vladimir Davydov <vdavydov@virtuozzo.com>,
        Johannes Weiner <hannes@cmpxchg.org>, Minchan Kim <minchan@kernel.org>,
        Hugh Dickins <hughd@google.com>
Date: Fri, 27 May 2016 09:40:27 -0700
In-Reply-To: <1462309280.21143.8.camel@linux.intel.com>
References: <cover.1462306228.git.tim.c.chen@linux.intel.com>
	 <1462309280.21143.8.camel@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-05-03 at 14:01 -0700, Tim Chen wrote:
> This patch prepares the code for being able to batch the anonymous
> pages
> to be swapped out.  It reorganizes shrink_page_list function with
> 2 new functions: handle_pgout and pg_finish.
> 
> The paging operation in shrink_page_list is consolidated into
> handle_pgout function.
> 
> After we have scanned a page shrink_page_list and completed any
> paging,
> the final disposition and clean up of the page is conslidated into
> pg_finish.  The designated disposition of the page from page scanning
> in shrink_page_list is marked with one of the designation in
> pg_result.
> 
> This is a clean up patch and there is no change in functionality or
> logic of the code.

Hi Michal,

We've talked about doing the clean up of shrink_page_list code
before attempting to do batching on the swap out path as those
set of patches I've previously posted are quit intrusive.  Wonder
if you have a chance to look at this patch and has any comments?

Thanks.

Tim