From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932800AbcE3H5K (ORCPT ); Mon, 30 May 2016 03:57:10 -0400 Received: from mga01.intel.com ([192.55.52.88]:55415 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932382AbcE3H5I (ORCPT ); Mon, 30 May 2016 03:57:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,388,1459839600"; d="scan'208";a="987286857" Message-ID: <1464595081.27624.48.camel@linux.intel.com> Subject: Re: WMI driver no longer load after switching to generic UUID library From: Andy Shevchenko To: Linus Torvalds , Kui Zhang Cc: Darren Hart , Andrew Morton , Linux Kernel Mailing List Date: Mon, 30 May 2016 10:58:01 +0300 In-Reply-To: References: Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.2-2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-05-29 at 13:22 -0700, Linus Torvalds wrote: > Andy? > > Looking at that commit, it does look like what wmi_parse_guid + > wmi_swap_bytes did was to implement a LE uuid. So the conversion looks > correct, but the fact that it breaks something obviously means that > there's something missing. What's going on? I proposed to add print to the loops to see what's going on there. > > And dammit, how I hate uuid's and the idiotic byte ordering issue. > It's possibly the only idiotic standard that is even worse than xml. T'so seems has the same opinion http://www.spinics.net/lists/kernel/msg2 263333.html > >             Linus > > On Sun, May 29, 2016 at 11:35 AM, Kui Zhang > wrote: > > Hello, > > > > After commit 538d7eb86d58 ("drivers/platform/x86/wmi.c: use generic > > UUID library") > > > > some keyboard functions stopped working: > > > > clevo-wmi - git://git.code.sf.net/p/clevo-wmi/code > > [   83.877887] Clevo Get GUID not found > > > > /* > > #define CLWMI_GET_GUID "ABBC0F6D-8EA1-11d1-00A0-C90629100000" > > > > ... > >     if(!wmi_has_guid(CLWMI_GET_GUID)) { > >         pr_err("Clevo Get GUID not found\n"); > >         return -ENODEV; > >     } > > > > > > */ > > > > clevo-xsm-wmi - https://bitbucket.org/lynthium/clevo-xsm-wmi.git > > insmod: ERROR: could not insert module clevo-xsm-wmi.ko: No such > > device > > > > /* > > > > #define CLEVO_GET_GUID    "ABBC0F6D-8EA1-11D1-00A0-C90629100000" > > > > ... > > > >     if (!wmi_has_guid(CLEVO_GET_GUID)) { > >         CLEVO_XSM_INFO("No known WMI control method GUID found\n"); > >         return -ENODEV; > >     } > > > > */ > > > > > > thanks > > Kui.Z -- Andy Shevchenko Intel Finland Oy