From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754305AbcE3I0O (ORCPT ); Mon, 30 May 2016 04:26:14 -0400 Received: from mga11.intel.com ([192.55.52.93]:47442 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932765AbcE3IYo (ORCPT ); Mon, 30 May 2016 04:24:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,388,1459839600"; d="scan'208";a="977126915" Message-ID: <1464596756.27624.51.camel@linux.intel.com> Subject: Re: [patch v2 net-next 12/13] net: hns: implement the miscellaneous operation by asl From: Andy Shevchenko To: Kejian Yan , rjw@rjwysocki.net, lenb@kernel.org, davem@davemloft.net Cc: fengguang.wu@intel.com, andrew@lunn.ch, ivecera@redhat.com, f.fainelli@gmail.com, haifeng.wei@huawei.com, charles.chenxin@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linuxarm@huawei.com Date: Mon, 30 May 2016 11:25:56 +0300 In-Reply-To: <1464574222-69608-13-git-send-email-yankejian@huawei.com> References: <1464574222-69608-1-git-send-email-yankejian@huawei.com> <1464574222-69608-13-git-send-email-yankejian@huawei.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.2-2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-05-30 at 10:10 +0800, Kejian Yan wrote: > The miscellaneous operation is implemented in BIOS, the kernel can > call > _DSM method help to call the implementation in ACPI case. Here is a > patch > to do that. > > +static phy_interface_t hns_mac_get_phy_if_acpi(struct hns_mac_cb > *mac_cb) > +{ > + phy_interface_t phy_if = PHY_INTERFACE_MODE_NA; > + union acpi_object *obj; > + union acpi_object obj_args, argv4; > + > + obj_args.integer.type = ACPI_TYPE_INTEGER; > + obj_args.integer.value = mac_cb->mac_id; > + > + argv4.type = ACPI_TYPE_PACKAGE, > + argv4.package.count = 1, > + argv4.package.elements = &obj_args, > + > + obj = acpi_evaluate_dsm(ACPI_HANDLE(mac_cb->dev), > + hns_dsaf_acpi_dsm_uuid, 0, > + HNS_OP_GET_PORT_TYPE_FUNC, &argv4); > + > + if (!obj || obj->type != ACPI_TYPE_INTEGER) Seems you have potential memory leak here if (!obj)  return phy_if; if (obj->...)  goto exit_free; > + return phy_if; > + > + phy_if = obj->integer.value ? > + PHY_INTERFACE_MODE_XGMII : PHY_INTERFACE_MODE_SGMII; > + > + dev_dbg(mac_cb->dev, "mac_id=%d, phy_if=%d\n", mac_cb- > >mac_id, phy_if); > + + exit_free: > + ACPI_FREE(obj); > + > + return phy_if; > +} > -- Andy Shevchenko Intel Finland Oy