From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754834AbcE3MG7 (ORCPT ); Mon, 30 May 2016 08:06:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57192 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754323AbcE3MG6 convert rfc822-to-8bit (ORCPT ); Mon, 30 May 2016 08:06:58 -0400 Message-ID: <1464610010.5179.34.camel@redhat.com> Subject: Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support From: Gerd Hoffmann To: Daniel Vetter Cc: dri-devel , open list , "open list:VIRTIO GPU DRIVER" Date: Mon, 30 May 2016 14:06:50 +0200 In-Reply-To: <20160530084233.GA27098@phenom.ffwll.local> References: <1443787104-24243-1-git-send-email-kraxel@redhat.com> <1443787104-24243-8-git-send-email-kraxel@redhat.com> <1464335163.10663.7.camel@redhat.com> <20160527075027.GW27098@phenom.ffwll.local> <20160530084233.GA27098@phenom.ffwll.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 30 May 2016 12:06:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > But I'll take you up on the implied offer to help out and test ;-) > > git://people.freedesktop.org/~danvet/drm stuff Tried that branch. > Would be really awesome if you could test this on virtio. Note that the > new nonblocking helpers require that your atomic backend gets the drm > event handling right. So if there's a bug in that logic then you'll see > lots of dmesg noise about waits timing out (after 10s of waiting). From a > quick inspection it should work though. No timeouts. Yay! But it seems crtcs can be (temporarely) disabled now, so we might have to pick up the crtc from old_state in virtio_gpu_plane_atomic_update to figure which virtual output needs to be turned off. Ran into this last week already. Happened with multihead setups only, but the same patch fixes this one too ;) https://lists.freedesktop.org/archives/dri-devel/2016-May/108772.html cheers, Gerd