From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755543AbcEaHes (ORCPT ); Tue, 31 May 2016 03:34:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60290 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755290AbcEaHer convert rfc822-to-8bit (ORCPT ); Tue, 31 May 2016 03:34:47 -0400 Message-ID: <1464680085.5978.40.camel@redhat.com> Subject: Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support From: Gerd Hoffmann To: Daniel Vetter Cc: dri-devel , open list , "open list:VIRTIO GPU DRIVER" Date: Tue, 31 May 2016 09:34:45 +0200 In-Reply-To: References: <1443787104-24243-1-git-send-email-kraxel@redhat.com> <1443787104-24243-8-git-send-email-kraxel@redhat.com> <1464335163.10663.7.camel@redhat.com> <20160527075027.GW27098@phenom.ffwll.local> <20160530084233.GA27098@phenom.ffwll.local> <1464610010.5179.34.camel@redhat.com> <20160530144325.GJ27098@phenom.ffwll.local> <1464675500.5978.15.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 31 May 2016 07:34:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > Right now the virtual outputs are linked to drm_crtc. To apply any > > changes I need to lookup the crtc to figure which virtual output should > > be updated. > > So, setting active_only should make sure I have a valid crtc pointer on > > plane updates, right? It probably also skips the disable + enable crtc > > steps on commit? What happens when outputs are disabled? > Nah, I just misunderstood your patch. If it's all about finding the > corresponding crtc, then you're all good. Yes, it's all about finding the crtc. > I thought there was some > other reason (like the virtual hw getting upset about certain things). virtio wouldn't be upset. It's a pointless exercise though to first disable the output, just to re-enable it the next moment with the new page-flipped framebuffer. So I guess I should look at the active_only thing nevertheless. > btw can you pls drop an ack or r-b > onto my virtio conversion? I already added your tested-by. Grr, mail is not in my dri-devel folder. Guess that is the "avoid-duplicates" mailman option at work. Feel free to just add the r-b too. Or I'll send it for the next version of the series. cheers, Gerd