From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754581AbcEaNJS (ORCPT ); Tue, 31 May 2016 09:09:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36344 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754532AbcEaNJQ convert rfc822-to-8bit (ORCPT ); Tue, 31 May 2016 09:09:16 -0400 Message-ID: <1464700153.5978.107.camel@redhat.com> Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer From: Gerd Hoffmann To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: dri-devel@lists.freedesktop.org, open list Date: Tue, 31 May 2016 15:09:13 +0200 In-Reply-To: <20160531123622.GT4329@intel.com> References: <1464691994-5704-1-git-send-email-kraxel@redhat.com> <1464691994-5704-5-git-send-email-kraxel@redhat.com> <20160531123622.GT4329@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 31 May 2016 13:09:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Di, 2016-05-31 at 15:36 +0300, Ville Syrjälä wrote: > Why store it in the fb and not eg. the plane state? Well, drm_plane_state is allocated by drm_atomic_helper_update_plane. When sticking the hotspot into the the plane state we have to add hot_x and hot_y parameters to drm_plane_funcs->update_plane() and cause quite some churn all over the drm tree. Or create a separate code path for cursor updates which uses a special drm_atomic_helper_update_plane version, which doesn't look very attractive too due to code duplication. Sticking it into the drm_framebuffer instead looks like a reasonable alternative. I'm open to better suggestions. cheers, Gerd