From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951AbcFBBYd (ORCPT ); Wed, 1 Jun 2016 21:24:33 -0400 Received: from host.buserror.net ([209.198.135.123]:58218 "EHLO host.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbcFBBYa (ORCPT ); Wed, 1 Jun 2016 21:24:30 -0400 Message-ID: <1464830660.22191.6.camel@buserror.net> From: Scott Wood To: Arnd Bergmann , linuxppc-dev@lists.ozlabs.org Cc: Ulf Hansson , Yangbo Lu , Mark Rutland , Xiaobo Xie , "linux-i2c@vger.kernel.org" , "linux-clk@vger.kernel.org" , Qiang Zhao , Russell King , Bhupesh Sharma , Joerg Roedel , Claudiu Manoil , "devicetree@vger.kernel.org" , Rob Herring , Santosh Shilimkar , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yang-Leo Li , "iommu@lists.linux-foundation.org" , Kumar Gala , linuxppc-dev@lists.ozlabs.org Date: Wed, 01 Jun 2016 20:24:20 -0500 In-Reply-To: <5513501.AmZs7h1vI2@wuerfel> References: <1462417950-46796-1-git-send-email-yangbo.lu@nxp.com> <5513501.AmZs7h1vI2@wuerfel> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 75.72.173.242 X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Subject: Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of arch/powerpc" X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on host.buserror.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-05-30 at 15:18 +0200, Arnd Bergmann wrote: > All users of this driver are PowerPC specific and the header file > has no business in the global include/linux/ hierarchy, so move > it back before anyone starts using it on ARM. > > This reverts commit 948486544713492f00ac8a9572909101ea892cb0. > > Signed-off-by: Arnd Bergmann > --- > This part of the series is not required for the eSDHC quirk, > but it restores the asm/fsl_guts.h header so it doesn't accidentally > get abused for this in the future. I found two drivers outside of > arch/powerpc that already accessed the registers directly, but the > functions look fairly contained, and can be easily hidden in an > #ifdef CONFIG_PPC NACK Besides adding ifdef pollution for no good reason, this register block is used on some ARM chips as well. Why is it a problem if "anyone starts using it on ARM"? BTW, of all the mailing lists you included on this CC, you seem to have left off the PPC list (I've added it). -Scott