From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752182AbcFBBsp (ORCPT ); Wed, 1 Jun 2016 21:48:45 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35504 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbcFBBsn (ORCPT ); Wed, 1 Jun 2016 21:48:43 -0400 From: Vinay Simha BN Cc: Vinay Simha BN , John Stultz , Sumit Semwal , Archit Taneja , Rob Clark , David Airlie , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] drm/dsi: Implement dcs backlight brightness Date: Thu, 2 Jun 2016 07:18:19 +0530 Message-Id: <1464832099-22402-2-git-send-email-simhavcs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464832099-22402-1-git-send-email-simhavcs@gmail.com> References: <1464832099-22402-1-git-send-email-simhavcs@gmail.com> To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Provide a small convenience wrapper that set/get the backlight brightness control and creates the backlight device for the panel interface Cc: John Stultz Cc: Sumit Semwal Cc: Archit Taneja Cc: Rob Clark Signed-off-by: Vinay Simha BN -- v1: *tested in nexus7 2nd gen. --- drivers/gpu/drm/drm_mipi_dsi.c | 63 ++++++++++++++++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 3 ++ 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 2f0b85c..ac4521e 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -1026,6 +1026,69 @@ int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format) } EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format); +static int dsi_dcs_bl_get_brightness(struct backlight_device *bl) +{ + struct mipi_dsi_device *dsi = bl_get_data(bl); + int ret; + u8 brightness; + + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; + + ret = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS, + &brightness, sizeof(brightness)); + if (ret < 0) + return ret; + + dsi->mode_flags |= MIPI_DSI_MODE_LPM; + + return brightness; +} + +static int dsi_dcs_bl_update_status(struct backlight_device *bl) +{ + struct mipi_dsi_device *dsi = bl_get_data(bl); + int ret; + u8 brightness = bl->props.brightness; + + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; + + ret = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, + &brightness, sizeof(brightness)); + if (ret < 0) + return ret; + + dsi->mode_flags |= MIPI_DSI_MODE_LPM; + + return 0; +} + +static const struct backlight_ops dsi_bl_ops = { + .update_status = dsi_dcs_bl_update_status, + .get_brightness = dsi_dcs_bl_get_brightness, +}; + +/** + * drm_panel_create_dsi_backlight() - creates the backlight device for the panel + * @dsi: DSI peripheral device + * + * @return a struct backlight on success, or an ERR_PTR on error + */ +struct backlight_device + *drm_panel_create_dsi_backlight(struct mipi_dsi_device *dsi) +{ + struct device *dev = &dsi->dev; + struct backlight_properties props; + + memset(&props, 0, sizeof(props)); + props.type = BACKLIGHT_RAW; + props.brightness = 255; + props.max_brightness = 255; + + return devm_backlight_device_register(dev, dev_name(dev), dev, dsi, + &dsi_bl_ops, &props); +} +EXPORT_SYMBOL(drm_panel_create_dsi_backlight); + static int mipi_dsi_drv_probe(struct device *dev) { struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver); diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 2788dbe..9dd6a97 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -12,6 +12,7 @@ #ifndef __DRM_MIPI_DSI_H__ #define __DRM_MIPI_DSI_H__ +#include #include struct mipi_dsi_host; @@ -269,6 +270,8 @@ int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, enum mipi_dsi_dcs_tear_mode mode); int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format); +struct backlight_device + *drm_panel_create_dsi_backlight(struct mipi_dsi_device *dsi); /** * struct mipi_dsi_driver - DSI driver -- 1.9.1