From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932759AbcFCM7a (ORCPT ); Fri, 3 Jun 2016 08:59:30 -0400 Received: from mga04.intel.com ([192.55.52.120]:64478 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757AbcFCM73 (ORCPT ); Fri, 3 Jun 2016 08:59:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,412,1459839600"; d="scan'208";a="990370474" Message-ID: <1464958844.1767.50.camel@linux.intel.com> Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data From: Andy Shevchenko To: Benjamin Tissoires Cc: Jiri Kosina , Bastien Nocera , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 03 Jun 2016 16:00:44 +0300 In-Reply-To: <20160603122305.GH6063@mail.corp.redhat.com> References: <20160513144927.GZ23234@mail.corp.redhat.com> <1463155787.17131.351.camel@linux.intel.com> <1463156908.17131.353.camel@linux.intel.com> <20160520075835.GJ23234@mail.corp.redhat.com> <20160531160741.GX23234@mail.corp.redhat.com> <1464717399.1767.1.camel@linux.intel.com> <20160602141127.GZ23234@mail.corp.redhat.com> <1464878415.1767.27.camel@linux.intel.com> <20160603093855.GC6063@mail.corp.redhat.com> <1464955145.1767.44.camel@linux.intel.com> <20160603122305.GH6063@mail.corp.redhat.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.2-2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-06-03 at 14:23 +0200, Benjamin Tissoires wrote: > On Jun 03 2016 or thereabouts, Andy Shevchenko wrote: > > On Fri, 2016-06-03 at 11:38 +0200, Benjamin Tissoires wrote: > > > On Jun 02 2016 or thereabouts, Andy Shevchenko wrote: > > > > On Thu, 2016-06-02 at 16:11 +0200, Benjamin Tissoires wrote: > > > > I take linux-next + your two patches from this thread (+ some > > > > unrelated > > > > to HID patches). > > > > > > OK. I think I know what happened: > > > - Microsoft forgot to put the Win 8 certification blob in this > > >   particular device (of course, because Microsoft) > > > - we do not detect it as a Win 8 certified and do not set the > > >   HID_QUIRK_NO_INIT_REPORTS flag > > > - your dmesg should show some error on plug, and then hid can't > > > set > > > the > > >   input mode > > > - I can't add a "if win 8 then show the mouse collection" because > > > your > > >   device doesn't report itself as win 8 :) > > > > > > Anyway, could you try applying this small diff after my 2 patches > > > and > > > report if you now have a working touchpad?: > > > > Nope. There is still no /dev/input/eventX associated with touchpad. > > Weird. On my system, if I replay your logs, I see 4 new nodes: > /dev/input/event21: Microsoft Surface Keyboard Keyboard > /dev/input/event22: Microsoft Surface Keyboard Consumer Control > /dev/input/event23: Microsoft Surface Keyboard Touchpad > /dev/input/event24: Microsoft Surface Keyboard Keyboard I had a line in dmesg that input8 is allocated to Touchpad, but no eventX (0..6 IIRC) from /dev/input reflects Touchpad events. I can get them only via /dev/usb/hiddev0. > > Can you attach the dmesg when plugging in the type cover? > I will do later, but there is no such thing 'plugging in'. It's a part of the notebook, so, I can do detach-attach cycle, though it shouldn't matter, it should work immediately after boot I suppose. -- Andy Shevchenko Intel Finland Oy