Re: [PATCH 0/5] Hi655x powerkey support for HiKey (v2)

Lee Jones
2016-06-08T15:37:33Z

On Fri, 03 Jun 2016, John Stultz wrote:

> This patchset enables the pmic powerkey to function on HiKey.
>
> I wanted to submit it for some initial review. Feedback would
> be greatly appreciated!
>
> New in v2:
> * Larger rework to the powerkey driver, integrating feedback
> from Dmitry
> * Minor dts cleanup suggested by Rob

Looks like I reviewed your RFC instead.

The points are still valid here though.

> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Guodong Xu <guodong.xu@linaro.org>
>
>
> Guodong Xu (1):
> arm64: dts: Add powerkey info to pmic for hi6220-hikey
>
> John Stultz (3):
> dts: bindings: Add binding documentation for hisilicon,hi6552-powerkey
> hi655x-pmic: Make hi655x pmic logic probe child nodes in the dt
> hi655x-pmic: Fixup issue with un-acked interrupts
>
> Jorge Ramirez-Ortiz (1):
> drivers: input: powerkey for HISI 65xx SoC
>
> .../bindings/input/hisilicon,hi6552-powerkey.txt | 40 ++++++
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 7 +
> drivers/input/misc/Kconfig | 9 ++
> drivers/input/misc/Makefile | 1 +
> drivers/input/misc/hisi_powerkey.c | 155 +++++++++++++++++++++
> drivers/mfd/hi655x-pmic.c | 9 ++
> 6 files changed, 221 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/hisilicon,hi6552-powerkey.txt
> create mode 100644 drivers/input/misc/hisi_powerkey.c
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog