From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753164AbcFCW2E (ORCPT ); Fri, 3 Jun 2016 18:28:04 -0400 Received: from p3plsmtps2ded01.prod.phx3.secureserver.net ([208.109.80.58]:42020 "EHLO p3plsmtps2ded01.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752953AbcFCW2C (ORCPT ); Fri, 3 Jun 2016 18:28:02 -0400 x-originating-ip: 72.167.245.219 From: "K. Y. Srinivasan" To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com Cc: "K. Y. Srinivasan" Subject: [PATCH 3/3] Drivers: hv: don't leak memory in vmbus_establish_gpadl() Date: Fri, 3 Jun 2016 17:09:24 -0700 Message-Id: <1464998964-24901-3-git-send-email-kys@microsoft.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1464998964-24901-1-git-send-email-kys@microsoft.com> References: <1464998940-24860-1-git-send-email-kys@microsoft.com> <1464998964-24901-1-git-send-email-kys@microsoft.com> X-CMAE-Envelope: MS4wfFrIHRtqhTIzu1BJpVBgk672VD4V1tBbLRGNbSXGyfXVmuv6MTNxF0KbZAxCCQSkaj21FFEnuarZDErJA+a+CuPRQcv/6FqaN6M9jSImSgqHLd59F02B dRdxikyLbsUlArltQPmTEAl5sl141Sf+GkhTISRSJfiMw00A4HceuSDaB9JiGxSRSchmwVfHLt6n1d2lQRtaTG8oEjOszAME2rUtNdHEhatrX0gSsAng9H8W fEnn9H2pV4zVwuBF/K82YZqUJ/+4M1DeDJi7bk6fq92nlDk55TBJ9Xelh0KPckp5BIUHDzAKuNJV9m9G6Xr92c0fQNYK0iQqS6GFgp6RMza2Gw7GaC4nrDDL WtDqY3mCU/ewNrUsWTwDvZRfz9H+qZ+uV7/FtkeCBr9iYXLgUAwAImA1Uxtcqwx2MvaxytthoYcR10A0gfcnVjod/qNUClFTj5Jm/VeinOYUWJlNhh0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vitaly Kuznetsov In some cases create_gpadl_header() allocates submessages but we never free them. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index 2b109e8..a68830c 100644 --- a/drivers/hv/channel.c +++ b/drivers/hv/channel.c @@ -388,7 +388,7 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer, struct vmbus_channel_gpadl_header *gpadlmsg; struct vmbus_channel_gpadl_body *gpadl_body; struct vmbus_channel_msginfo *msginfo = NULL; - struct vmbus_channel_msginfo *submsginfo; + struct vmbus_channel_msginfo *submsginfo, *tmp; struct list_head *curr; u32 next_gpadl_handle; unsigned long flags; @@ -445,6 +445,10 @@ cleanup: spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_del(&msginfo->msglistentry); spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags); + list_for_each_entry_safe(submsginfo, tmp, &msginfo->submsglist, + msglistentry) { + kfree(submsginfo); + } kfree(msginfo); return ret; -- 1.7.4.1